This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
Improve horizontal scrolling behavior #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, horizontal scroll-wheel events are handled oddly. The scroll wheel can never be used to scroll horizontally, even when a horizontal scrollbar is present (contradicting the behavior described in the
scroll_wheel_eventdocstring), and both scroll protection and theflip with wheelpreference are ignored if the page would be turned forwards.This patch permits horizontal scrolling when applicable and respects protection (and therefore
flip with wheel) in all directions._scroll_with_flippingalready handles manga mode, so there's no need for this logic inscroll_wheel_event.