Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sourceResourceRoot for client-sided events #4021

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix sourceResourceRoot for client-sided events #4021

wants to merge 2 commits into from

Conversation

Nico8340
Copy link
Contributor

@Nico8340 Nico8340 commented Feb 13, 2025 •
edited
Loading

Fixes #2965

@TheNormalnij TheNormalnij added the backwards-incompatible Should be merged after the release of 1.6.1 label Feb 13, 2025
@Dutchman101
Copy link
Member

Can you clarify the way this is backwards incompatible?

@Nico8340
Copy link
Contributor Author

Can you clarify the way this is backwards incompatible?

@TheNormalnij?

@TheNormalnij
Copy link
Member

Can you clarify the way this is backwards incompatible?

I think some developers know current behavior and have some workarounds for it. getElementParent returns a different element for sourceResourceRoot after these changes.
I suggest merging it with 1.6.1 release to not repeat a story with SVG,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backwards-incompatible Should be merged after the release of 1.6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sourceResourceRoot is incorrect in event handlers
3 participants
@Nico8340 @Dutchman101 @TheNormalnij