added resource: Chemical Ladder v2.0 (ladders) #547

ChemicalCreations · 2024-09-03T19:50:02Z

Adds a resource that allows you to climb various ladders across SA map. Default ladders can be added or disabled via exported functions. This also allows you to add ladders to elements based on modelID (vehicle and object supported).
https://youtu.be/K3JhbzGyQto?si=84lkPPM4I3R189mh

jlillis · 2024-09-04T17:04:38Z

Looks pretty cool. This is going to take a while to code review, but the first step would be to look at what the linter has flagged and address those issues.

Just to confirm on the record - are you the original author of the resource?

ChemicalCreations · 2024-09-04T18:22:07Z

For the record yes.

Fernando-A-Rocha · 2024-09-05T14:57:06Z

Awesome scripts! Looking forward to this

Nico8340 · 2024-10-12T23:34:31Z

Any updates on this?

AlexTMjugador · 2024-11-14T09:05:45Z

Any updates on this?

[...] the first step would be to look at what the linter has flagged and address those issues.

This step was not done as far as I can see, so no, there are no updates.

Nico8340 · 2025-01-13T14:57:47Z

[gameplay]/ladders/client.lua

+local climbers = {}
+local climbs = {}
+
+local anim = anims


This is unnecessary, because the anims table is a global variable, so it is accessible in this script from the global namespace

Suggested change

local anim = anims

Nico8340 · 2025-01-13T15:00:42Z

[gameplay]/ladders/client.lua

+local minus
+do
+	local abs = math.abs
+	-- calculate and return the distance unit2 
+	-- needs to move to reach unit1
+	function minus(unit1, unit2)
+		local phi = abs(unit2-unit1) % 360
+		local sign = 1
+		-- used to calculate sign
+		if not ((unit1-unit2 >= 0 and unit1-unit2 <= 180)
+		or (unit1-unit2 <= -180 and unit1-unit2 >= -360)) then
+			sign = -1
+		end
+		if phi > 180 then
+			result = 360-phi
+		else
+			result = phi
+		end
+
+		return result*sign
+	end
+end


This can be implemented much more simply, how about this solution?

Suggested change

local minus

do

local abs = math.abs

-- calculate and return the distance unit2

-- needs to move to reach unit1

function minus(unit1, unit2)

local phi = abs(unit2-unit1) % 360

local sign = 1

-- used to calculate sign

if not ((unit1-unit2 >= 0 and unit1-unit2 <= 180)

or (unit1-unit2 <= -180 and unit1-unit2 >= -360)) then

sign = -1

end

if phi > 180 then

result = 360-phi

else

result = phi

end

return result*sign

end

end

function minus(unit1, unit2)

local diff = unit2 - unit1

local diffNormalized = diff % 360

return diffNormalized > 180 and diffNormalized - 360 or diffNormalized

end

Looks good, don't see why not as long as it works.

Nico8340 · 2025-01-13T15:01:28Z

[gameplay]/ladders/client.lua

+function getPedsOnLadder(surface)
+    local peds = {}
+    for ped, data in pairs(climbers) do
+        if surface==nil then


Suggested change

if surface==nil then

if not surface then

I wouldn't recommend that. nil and false aren't the same, they are done like that for a reason.

I wouldn't recommend that. nil and false aren't the same, they are done like that for a reason.

In this case, it will not change how it works, and the change I suggested is a better solution

Nico8340 · 2025-01-13T15:01:51Z

[gameplay]/ladders/client.lua

+function isPedLadderClimbingEnabled(ped)
+    local eType = ped and isElement(ped) and getElementType(ped)
+    assert(eType=="ped" or eType=="player") -- isPed
+    if climbers[ped]==false then return false end


Suggested change

if climbers[ped]==false then return false end

if not climbers[ped] then return false end

Nico8340 · 2025-01-13T15:03:49Z

[gameplay]/ladders/client.lua

+			local dist = ((tx-sx)^2+(ty-sy)^2+(tz-sz)^2)^.5+10
+			if ((tx-px)^2+(ty-py)^2+(tz-pz)^2)^.5<dist or ((px-sx)^2+(py-sy)^2+(pz-sz)^2)^.5<dist then
+				local dist, p = getPointDistanceFromLadder(px, py, pz, sx, sy, sz, tx, ty, tz)
+				if (climbD==nil or dist<climbD) then


Suggested change

if (climbD==nil or dist<climbD) then

if (not climbD or dist<climbD) then

ChemicalCreations · 2025-01-16T21:55:14Z

[gameplay]/ladders/server.lua

+    local eType = ped and isElement(ped) and getElementType(ped)
+    assert(eType=="ped" or eType=="player") -- isPed
+    if climbers[ped]==false then return false end
+    return climbers[ped]==nil or (climbers[ped] and true)


Do realize this is supposed to return true when it's nil.

Nico8340 · 2025-01-13T15:10:56Z

[gameplay]/ladders/server.lua

+    return false
+end
+
+do


Why is this do block necessary?

Nico8340 · 2025-01-13T15:11:16Z

[gameplay]/ladders/server.lua

+function removeLadder(surface, ladder)
+	local surfaceData = climbs[surface]
+    assert(surfaceData)
+    if ladder==nil then


Suggested change

if ladder==nil then

if not ladder then

Nico8340 · 2025-01-13T15:12:07Z

[gameplay]/ladders/server.lua

+addDebugHook("preFunction", function(sourceResource, functionName, isAllowedByACL, luaFilename, luaLineNumber, ped) -- just to deal with freeroam
+	if sourceResource~=resource and climbers[ped] then
+		return "skip"
+	end
+end, {"setPedAnimation"})


Not a good idea

Nico8340 · 2025-01-13T15:12:41Z

[gameplay]/ladders/server.lua

+addDebugHook("postFunction", function(sourceResource, functionName, isAllowedByACL, luaFilename, luaLineNumber, ...)
+end, {"createVehicle", "Vehicle", "createObject", "Object"})


Not used for anything

ChemicalCreations · 2025-01-16T21:55:14Z

[gameplay]/ladders/server.lua

+    local eType = ped and isElement(ped) and getElementType(ped)
+    assert(eType=="ped" or eType=="player") -- isPed
+    if climbers[ped]==false then return false end
+    return climbers[ped]==nil or (climbers[ped] and true)


Do realize this is supposed to return true when it's nil.

Xenius97 · 2025-02-08T19:37:50Z

This resource is very unoptimized.
5 debug hooks?? Are you serious? RIP server performance

ChemicalCreations · 2025-02-08T21:26:37Z

This resource is very unoptimized.
5 debug hooks?? Are you serious? RIP server performance

Is debughook really that heavy? Even with specifying the function/event???

Xenius97 · 2025-02-08T21:29:34Z

Is debughook really that heavy? Even with specifying the function/event???

Yes, we used just one in the past for logging a single function, and the server performance dropped by about 60%. And you have 5 hooks.

ChemicalCreations · 2025-02-08T21:35:30Z

And you got the same result with this resource??? Or is it something you haven't tried.

Xenius97 · 2025-02-08T21:38:28Z

No i've didnt use this resource, just noticed this. But this can cause problem on bigger servers.

ds1-e · 2025-02-08T22:05:47Z

And you got the same result with this resource??? Or is it something you haven't tried.

The debug part is there for a reason.

PlatinMTA · 2025-02-08T22:47:07Z

This resource is very unoptimized.
5 debug hooks?? Are you serious? RIP server performance

Is debughook really that heavy? Even with specifying the function/event???

Its heavy depending on how many times you use those functions but yeah, it's heavy. You really should change your hooks to events and timers that check new objects. How many times would you actually create an object thats a ladder? Not that many, so either you check them every minute or so with a timer, you check them after other resource starts or you expect the server owner to communicate to ladders that a new ladder has been added.

Rule of thumb, if you are using debugHook for something other than anticheat you are probably doing something wrong. Even then its not recommended. For example onElementDestroy shouldnt be on a debugHook, just add an event and check there if the object of a ladder has been destroyed.

ChemicalCreations · 2025-02-08T22:52:46Z

Rule of thumb, if you are using debugHook for something other than anticheat you are probably doing something wrong. Even then its not recommended. For example onElementDestroy shouldnt be on a debugHook, just add an event and check there if the object of a ladder has been destroyed.

That's great but MTA doesn't offer element creation event Sooooo....... what's the next best thing yk. like you said, on resource start check, and probably checking elements type index if it changes etc, would be a better implementation

ds1-e · 2025-02-08T23:13:37Z

Rule of thumb, if you are using debugHook for something other than anticheat you are probably doing something wrong. Even then its not recommended. For example onElementDestroy shouldnt be on a debugHook, just add an event and check there if the object of a ladder has been destroyed.

That's great but MTA doesn't offer element creation event Sooooo....... what's the next best thing yk. like you said, on resource start check, and probably checking elements type index if it changes etc, would be a better implementation

You don't need element creation event, simply use stream-in/out event, this is when an element gets rendered (created) for client.

https://wiki.multitheftauto.com/wiki/OnClientElementStreamIn

added resource: Chemical Ladder v2.0 (ladders)

76eb9c6

jlillis added the enhancement label Sep 4, 2024

Nico8340 reviewed Jan 13, 2025

View reviewed changes

ChemicalCreations commented Jan 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added resource: Chemical Ladder v2.0 (ladders) #547

added resource: Chemical Ladder v2.0 (ladders) #547

ChemicalCreations commented Sep 3, 2024 •

edited

Loading

jlillis commented Sep 4, 2024

ChemicalCreations commented Sep 4, 2024

Fernando-A-Rocha commented Sep 5, 2024

Nico8340 commented Oct 12, 2024

AlexTMjugador commented Nov 14, 2024

Nico8340 Jan 13, 2025

Nico8340 Jan 13, 2025

ChemicalCreations Jan 16, 2025

Nico8340 Jan 13, 2025

ChemicalCreations Jan 16, 2025

Nico8340 Jan 16, 2025

Nico8340 Jan 13, 2025

Nico8340 Jan 13, 2025

ChemicalCreations Jan 16, 2025

Nico8340 Jan 13, 2025

Nico8340 Jan 13, 2025

Nico8340 Jan 13, 2025

ChemicalCreations Jan 16, 2025

Nico8340 Jan 13, 2025

ChemicalCreations Jan 16, 2025

Xenius97 commented Feb 8, 2025

ChemicalCreations commented Feb 8, 2025

Xenius97 commented Feb 8, 2025 •

edited

Loading

ChemicalCreations commented Feb 8, 2025

Xenius97 commented Feb 8, 2025

ds1-e commented Feb 8, 2025

PlatinMTA commented Feb 8, 2025 •

edited

Loading

ChemicalCreations commented Feb 8, 2025

ds1-e commented Feb 8, 2025 •

edited

Loading

	if climbers[ped]==false then return false end
	if not climbers[ped] then return false end

	if (climbD==nil or dist<climbD) then
	if (not climbD or dist<climbD) then

		addDebugHook("postFunction", function(sourceResource, functionName, isAllowedByACL, luaFilename, luaLineNumber, ...)
		end, {"createVehicle", "Vehicle", "createObject", "Object"})

added resource: Chemical Ladder v2.0 (ladders) #547

Are you sure you want to change the base?

added resource: Chemical Ladder v2.0 (ladders) #547

Conversation

ChemicalCreations commented Sep 3, 2024 • edited Loading

jlillis commented Sep 4, 2024

ChemicalCreations commented Sep 4, 2024

Fernando-A-Rocha commented Sep 5, 2024

Nico8340 commented Oct 12, 2024

AlexTMjugador commented Nov 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Xenius97 commented Feb 8, 2025

ChemicalCreations commented Feb 8, 2025

Xenius97 commented Feb 8, 2025 • edited Loading

ChemicalCreations commented Feb 8, 2025

Xenius97 commented Feb 8, 2025

ds1-e commented Feb 8, 2025

PlatinMTA commented Feb 8, 2025 • edited Loading

ChemicalCreations commented Feb 8, 2025

ds1-e commented Feb 8, 2025 • edited Loading

ChemicalCreations commented Sep 3, 2024 •

edited

Loading

Xenius97 commented Feb 8, 2025 •

edited

Loading

PlatinMTA commented Feb 8, 2025 •

edited

Loading

ds1-e commented Feb 8, 2025 •

edited

Loading