Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "//FIXME SMELL" comments in the code #813

Merged
merged 1 commit into from
Oct 11, 2024
+5 −0
Merged

Add "//FIXME SMELL" comments in the code #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/engine/tcr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,7 @@ func Test_tcr_cycle_end_state(t *testing.T) {
}
}

// FIXME SMELL: This test factory method is getting complicated with too many parameters. Consider refactoring to Builders.
func initTCREngineWithFakesWithFileDiffs(
p *params.Params,
toolchainFailures toolchain.Operations,
Expand Down
4 changes: 4 additions & 0 deletions src/report/reporter_test_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ func (sniffer *Sniffer) Stop() {
}
}

// FIXME SMELL: Duplicated assertion code in tests. Consider improving the reporter fake as a real mock with
// check method and better error reporting, ex: report.assertWarning... instead of setting up the sniffer
// then asserting count matches

// GetAllMatches returns a slice containing all matching messages captured by the sniffer
func (sniffer *Sniffer) GetAllMatches() []Message {
return sniffer.captured
Expand Down
Loading