Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input by duration: various fixes #26367

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Input by duration: various fixes #26367

wants to merge 6 commits into from

Conversation

RomanPudashkin
Copy link
Contributor

Resolves: #26363
Resolves: #26349
Resolves: #26345
Resolves: #26325
Resolves: #26327

This was referenced Feb 6, 2025
Open
Open
@DmitryArefiev DmitryArefiev mentioned this pull request Feb 7, 2025
Open
4 tasks
@DmitryArefiev
Copy link
Contributor

Tested #26349 #26345 #26325 #26327 on Win10, Mac13.6, LinuxUbuntu24.04.1 LTS - FIXED

#26363 fixed partially

mathesoncalum
mathesoncalum approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@mathesoncalum mathesoncalum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

My only question is whether m_rest in input.h is still necessary? It looks very closely linked to m_notes.empty() now (not a blocker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathesoncalum mathesoncalum mathesoncalum approved these changes

Assignees

@Tantacrul Tantacrul

@DmitryArefiev DmitryArefiev

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@RomanPudashkin @DmitryArefiev @mathesoncalum @Tantacrul