Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20998: Added a midi mapping for "Enter rest" #26377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krasko78
Copy link
Contributor

@krasko78 krasko78 commented Feb 7, 2025

Resolves: #20998

Adds a midi mapping for the "Enter rest" ui action which is also tied to the "Enter rest" shortcut (normally 0 and Num 0).

I think I am seeing a couple of issues with the "Enter rest" action in general:

  • In Rhythm only input mode, "Enter rest" acts as "Toggle rest". Is this expected? Does "Enter rest" make any sense in this mode at all?
  • More importantly, in Re-pitch only mode "Enter rest" enters a rest but changes the duration to the currently selected duration instead of retaining the whatever duration the underlying note has (similar to "Input by note name" mode). I don't think this is correct. Personally I enter my scores in Rhythm only mode, then Re-pitch only mode. During the first phase, I'd enter a rest as a note being interested only in its duration, and then during the second phase I'd change the note to a rest but I'd not expect the duration to change.

Thoughts?

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIDI remote control: add the "Enter rest" action
1 participant