feat: activity functions #2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| .idea | ||
| /config/conf.yaml | ||
| /test | ||
| /volumes |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| services: | ||
| kafka: | ||
| image: docker.io/bitnami/kafka:3.9 | ||
| container_name: kafka_EG | ||
| ports: | ||
| - "9092:9092" | ||
| volumes: | ||
| - ./volumes/kafka:/bitnami | ||
| environment: | ||
| # KRaft settings | ||
| - KAFKA_CFG_NODE_ID=0 | ||
| - KAFKA_CFG_PROCESS_ROLES=controller,broker | ||
| - KAFKA_CFG_CONTROLLER_QUORUM_VOTERS=0@kafka:9093 | ||
| # Listeners | ||
| - KAFKA_CFG_LISTENERS=PLAINTEXT://:9092,CONTROLLER://:9093 | ||
| - KAFKA_CFG_ADVERTISED_LISTENERS=PLAINTEXT://:9092 | ||
| - KAFKA_CFG_LISTENER_SECURITY_PROTOCOL_MAP=CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT | ||
| - KAFKA_CFG_CONTROLLER_LISTENER_NAMES=CONTROLLER | ||
| - KAFKA_CFG_INTER_BROKER_LISTENER_NAME=PLAINTEXT | ||
|
|
||
| zookeeper: | ||
| container_name: zookeeper_EG | ||
| image: docker.io/bitnami/zookeeper:3.9 | ||
| ports: | ||
| - '2181:2181' | ||
| volumes: | ||
| - ./volumes/zookeeper:/bitnami/zookeeper | ||
| environment: | ||
| - ALLOW_ANONYMOUS_LOGIN=yes | ||
|
|
||
| db: | ||
| image: mysql:8.0 | ||
| container_name: mysql_EG | ||
| restart: always | ||
| environment: | ||
| MYSQL_ROOT_PASSWORD: 114514 | ||
| ports: | ||
| - "3306:3306" | ||
| volumes: | ||
| - ./volumes/mysql:/var/lib/mysql | ||
|
|
||
|
Comment on lines
+31
to
+41
There was a problem hiding this comment. Critical: Address MySQL security concerns and configuration.
db:
image: mysql:8.0
container_name: mysql_EG
restart: always
environment:
- MYSQL_ROOT_PASSWORD: 114514
+ MYSQL_ROOT_PASSWORD: ${MYSQL_ROOT_PASSWORD}
+ MYSQL_DATABASE: ${MYSQL_DATABASE}
+ MYSQL_USER: ${MYSQL_USER}
+ MYSQL_PASSWORD: ${MYSQL_PASSWORD}
+ MYSQL_CHARACTER_SET_SERVER: utf8mb4
+ MYSQL_COLLATION_SERVER: utf8mb4_unicode_ci
ports:
- "3306:3306"
volumes:
- - ./volumes/mysql:/var/lib/mysql
+ - mysql_data:/var/lib/mysql
+ healthcheck:
+ test: ["CMD", "mysqladmin", "ping", "-h", "localhost"]
+ interval: 30s
+ timeout: 10s
+ retries: 3Create a MYSQL_ROOT_PASSWORD=your_secure_password
MYSQL_DATABASE=app_db
MYSQL_USER=app_user
MYSQL_PASSWORD=app_passwordAdd at the end of the file: volumes:
mysql_data:
driver: local |
||
| redis: | ||
| image: redis:7.0 | ||
| container_name: redis_EG | ||
| restart: always | ||
| ports: | ||
| - "6379:6379" | ||
| volumes: | ||
| - ./volumes/redis:/data | ||
|
|
||
|
Comment on lines
+42
to
+50
There was a problem hiding this comment. 🛠️ Refactor suggestion Enhance Redis security and performance configuration. Consider the following improvements:
redis:
image: redis:7.0
container_name: redis_EG
restart: always
+ command: redis-server --requirepass ${REDIS_PASSWORD} --maxmemory 512mb --maxmemory-policy allkeys-lru
ports:
- "6379:6379"
volumes:
- - ./volumes/redis:/data
+ - redis_data:/data
+ healthcheck:
+ test: ["CMD", "redis-cli", "ping"]
+ interval: 30s
+ timeout: 10s
+ retries: 3Add to REDIS_PASSWORD=your_secure_passwordAdd at the end of the file: volumes:
redis_data:
driver: local |
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid hardcoding database credentials.
The MySQL password should not be hardcoded in the source code. Instead, load it from environment variables or a secure configuration file.
Apply this diff to use environment variables:
Add these imports: