Skip to content

Commit

Permalink
Add test-unit-functional-integration and test-ui as dependencies for …
Browse files Browse the repository at this point in the history
…the ci and publish runs
  • Loading branch information
mwouts committed Dec 2, 2023
1 parent d509f2f commit 7fe3bc4
Show file tree
Hide file tree
Showing 5 changed files with 45 additions and 26 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ concurrency:
cancel-in-progress: true

jobs:
link-to-binder:
comment-pr:
permissions:
pull-requests: write
uses: ./.github/workflows/step_link-to-binder.yml
uses: ./.github/workflows/step_comment-pr.yml

pre-commit:
uses: ./.github/workflows/step_pre-commit.yml
Expand All @@ -59,7 +59,7 @@ jobs:
uses: ./.github/workflows/step_tests-ui.yml

build:
needs: [test-pip, test-conda, test-ui]
needs: [test-pip, test-conda, test-unit-functional-integration, test-ui]
uses: ./.github/workflows/step_build.yml
with:
upload: ${{ inputs.upload-build-artifacts || false }}
10 changes: 9 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,20 @@ jobs:
needs: [ codeql ]
uses: ./.github/workflows/step_tests-pip.yml

test-unit-functional-integration:
needs: [ codeql ]
uses: ./.github/workflows/step_test_unit_functional.yml

test-conda:
needs: [ codeql ]
uses: ./.github/workflows/step_tests-conda.yml

test-ui:
needs: [ codeql ]
uses: ./.github/workflows/step_tests-ui.yml

build:
needs: [ test-pip, test-conda ]
needs: [ test-pip, test-conda, test-unit-functional-integration, test-ui ]
uses: ./.github/workflows/step_build.yml

publish:
Expand Down
27 changes: 27 additions & 0 deletions .github/workflows/step_comment-pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: comment-pr
run-name: Comment PR

on:
workflow_call:

jobs:
comment-pr:
runs-on: ubuntu-latest
name: Comment PR
if: github.event_name == 'pull_request'
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Comment PR
uses: thollander/actions-comment-pull-request@v2
with:
message: |
Thank you for making this pull request. Did you know? You can try it on Binder: [![Binder:lab](https://img.shields.io/badge/binder-jupyterlab-0172B2.svg)](https://mybinder.org/v2/gh/${{ github.repository }}/${{ github.head_ref }}?urlpath=lab/tree/demo/get_started.ipynb) or [![Binder:notebook](https://img.shields.io/badge/binder-notebook-0172B2.svg)](https://mybinder.org/v2/gh/${{ github.repository }}/${{ github.head_ref }}?filepath=demo).
You can also test this PR in your environment with
```
pip install git+https://github.com/{{ github.repository }}.git@{{ github.head_ref }}
```
(this requires `nodejs`, see more at [Developing Jupytext](https://jupytext.readthedocs.io/en/latest/developing.html))
comment_tag: binder_link
21 changes: 0 additions & 21 deletions .github/workflows/step_link-to-binder.yml

This file was deleted.

7 changes: 6 additions & 1 deletion docs/developing.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ If you want to test a feature that has been integrated in `main` but not deliver
pip install git+https://github.com/mwouts/jupytext.git
```

If you want only to build Jupytext core (e.g. not the JupyterLab extension) you can prefix the
The above requires `node`. You can install it with e.g.
```
conda install 'nodejs>=20' -c conda-forge
```

Alternatively you can build only Jupytext core (e.g. skip the JupyterLab extension). To do so, prefix the
above with `HATCH_BUILD_HOOKS_ENABLE=false`.

Finally, if you want to test a development branch, use
Expand Down

0 comments on commit 7fe3bc4

Please sign in to comment.