Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create volume tests #10

Merged
merged 3 commits into from
Mar 28, 2024
Merged

fix: create volume tests #10

merged 3 commits into from
Mar 28, 2024

Conversation

mj0nez
Copy link
Contributor

@mj0nez mj0nez commented Mar 24, 2024

Requires #8
Closes #9

@mxab
Copy link
Owner

mxab commented Mar 28, 2024

Test run locally, since I merged #8 could you rebase this one?

@mj0nez mj0nez force-pushed the fix/create-volume-tests branch from 4600f43 to 508c5e5 Compare March 28, 2024 13:45
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mj0nez
Copy link
Contributor Author

mj0nez commented Mar 28, 2024

Done. After merging, could you do a new release for pypi? :)

@mxab mxab merged commit 2dd2ed0 into mxab:main Mar 28, 2024
2 of 3 checks passed
@mxab
Copy link
Owner

mxab commented Mar 28, 2024

https://pypi.org/project/jupyterhub-nomad-spawner/ 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests for volume creation fial
2 participants