fix: don't break when downloading docker images #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Firstly I'd like to thank you for your work on this as it's been very helpful at my company.
We faced a few issues where the spawner would break when downloading big docker images as it would mark a job as running when the task was still downloading the image hence failing to get the address of the allocation.
To fix this, instead of checking only for job status, this PR also introduces the check for the latest task status assuming that if the task is running the whole job is also running successfully.
Let me know if you have any questions or if you need any further changes.
Thanks!