Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't break when downloading docker images #12

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

jfmlima
Copy link
Contributor

@jfmlima jfmlima commented Feb 4, 2025

Hi,

Firstly I'd like to thank you for your work on this as it's been very helpful at my company.
We faced a few issues where the spawner would break when downloading big docker images as it would mark a job as running when the task was still downloading the image hence failing to get the address of the allocation.
To fix this, instead of checking only for job status, this PR also introduces the check for the latest task status assuming that if the task is running the whole job is also running successfully.

  • Fixes poetry command in dockerfile to update deprecated flag
  • Checks for task status as well when validating if a job is running successfully.

Let me know if you have any questions or if you need any further changes.

Thanks!

Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@mxab
Copy link
Owner

mxab commented Feb 5, 2025

Hey thank you very much for the nice feedback and the PR. I try to review asap just this week I'm very stuffed

@jfmlima
Copy link
Contributor Author

jfmlima commented Feb 13, 2025

Hey thank you very much for the nice feedback and the PR. I try to review asap just this week I'm very stuffed

Hey @mxab, any news here?

@mxab mxab merged commit e989c2f into mxab:main Feb 14, 2025
2 of 4 checks passed
@mxab
Copy link
Owner

mxab commented Feb 14, 2025

@jfmlima sorry for the delay, its merged. Thank you so much for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants