show() 改为input事件触发 #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/simditor-mention.coffee
Outdated
| return unless e.which is 229 | ||
| @editor.body.on 'input', (e)=> | ||
| # windows 的 firefox 下 e.which == 0, webkit 浏览器 e.which 是 undefined | ||
| return unless e.which is 0 or typeof e.which is 'undefined' |
There was a problem hiding this comment.
无论是不是ime输入，input事件的e.which都是0或者undefined吧？这一块代码是专门处理IME的逻辑
改用input事件的话应该就不能区分是否是IME输入了，所以应该有跟原来不同逻辑，同时兼容普通英文输入和IME输入
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.