Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark migration methods as non escaping #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mark migration methods as non escaping #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
320b75f
Update MTMigration.h
huguesbr Jan 15, 2018
035fa02
Update MTMigration.m
huguesbr Jan 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions MTMigration/MTMigration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ typedef void (^MTExecutionBlock)(void);

*/

+ (void) migrateToVersion:(NSString *)version block:(MTExecutionBlock)migrationBlock;
+ (void) migrateToVersion:(NSString *)version block:(__attribute__((noescape)) MTExecutionBlock)migrationBlock;

/**
Executes a block of code for a specific build number and remembers this build as the latest migration done by MTMigration.
Expand All @@ -32,7 +32,7 @@ typedef void (^MTExecutionBlock)(void);

*/

+ (void) migrateToBuild:(NSString *)build block:(MTExecutionBlock)migrationBlock;
+ (void) migrateToBuild:(NSString *)build block:(__attribute__((noescape)) MTExecutionBlock)migrationBlock;

/**

Expand All @@ -42,7 +42,7 @@ typedef void (^MTExecutionBlock)(void);

*/

+ (void) applicationUpdateBlock:(MTExecutionBlock)updateBlock;
+ (void) applicationUpdateBlock:(__attribute__((noescape)) MTExecutionBlock)updateBlock;

/**

Expand All @@ -52,7 +52,7 @@ typedef void (^MTExecutionBlock)(void);

*/

+ (void) buildNumberUpdateBlock:(MTExecutionBlock)updateBlock;
+ (void) buildNumberUpdateBlock:(__attribute__((noescape)) MTExecutionBlock)updateBlock;

/** Clears the last migration remembered by MTMigration. Causes all migrations to run from the beginning. */

Expand Down
8 changes: 4 additions & 4 deletions MTMigration/MTMigration.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
@implementation MTMigration


+ (void) migrateToVersion:(NSString *)version block:(MTExecutionBlock)migrationBlock {
+ (void) migrateToVersion:(NSString *)version block:(__attribute__((noescape)) MTExecutionBlock)migrationBlock {
// version > lastMigrationVersion && version <= appVersion
if ([version compare:[self lastMigrationVersion] options:NSNumericSearch] == NSOrderedDescending &&
[version compare:[self appVersion] options:NSNumericSearch] != NSOrderedDescending) {
Expand All @@ -34,7 +34,7 @@ + (void) migrateToVersion:(NSString *)version block:(MTExecutionBlock)migrationB
}


+ (void) migrateToBuild:(NSString *)build block:(MTExecutionBlock)migrationBlock
+ (void) migrateToBuild:(NSString *)build block:(__attribute__((noescape)) MTExecutionBlock)migrationBlock
{
// build > lastMigrationBuild && build <= appVersion
if ([build compare:[self lastMigrationBuild] options:NSNumericSearch] == NSOrderedDescending &&
Expand All @@ -50,7 +50,7 @@ + (void) migrateToBuild:(NSString *)build block:(MTExecutionBlock)migrationBlock
}


+ (void) applicationUpdateBlock:(MTExecutionBlock)updateBlock {
+ (void) applicationUpdateBlock:(__attribute__((noescape)) MTExecutionBlock)updateBlock {
if (![[self lastAppVersion] isEqualToString:[self appVersion]]) {
updateBlock();

Expand All @@ -63,7 +63,7 @@ + (void) applicationUpdateBlock:(MTExecutionBlock)updateBlock {
}


+ (void) buildNumberUpdateBlock:(MTExecutionBlock)updateBlock {
+ (void) buildNumberUpdateBlock:(__attribute__((noescape)) MTExecutionBlock)updateBlock {
if (![[self lastAppBuild] isEqualToString:[self appBuild]]) {
updateBlock();

Expand Down