-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the root sentry span to a resolver's context #1609
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 01624ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It seems surprising that my code would change the error handling? Is it known to be flaky? |
@orta can you add a changeset? |
Looks like just need to run prettier @orta |
on the markdown that gets thrown away? That should be in the exceptions |
CI is failing :/ |
Rerun it? All but one appear fine😄 And Orta is right with Prettier; .changeset shouldn't be linted |
@jeengbe Unit tests are failing :) |
Run it once more, it worked locally on the second attempt 🙂 |
fix: use Sentry.flush()
Co-authored-by: Jesper Engberg <[email protected]>
In response to getsentry/sentry-javascript#7083 (reply in thread), this might actually be the wrong solution to this problem. Instead, a PR that integrates this |
a23dec1
to
3ac13be
Compare
Description
Hello folks, I was going through Sentry tracing, and I needed access to set my parent span on a transaction. Now, this is reasonably easy to do via:
But relying on a bunch of globals feels a little bit off for me, when context is really what this sort of thing is for (IMO.) So, this PR adds span into the operation context. I've scoped it into a
sentry
object - in case there more things added further down the line.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: