Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve concurrency issues #251

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

milkshakeuk
Copy link
Member

Improves on changes made in this commit;

@iangralinski-invetech Could you take a look also, if you get chance?

@milkshakeuk milkshakeuk requested a review from AMCN41R November 30, 2021 14:21
@milkshakeuk milkshakeuk force-pushed the ConcurrencyImprovements branch from a1818b3 to 8444f41 Compare November 30, 2021 19:43
@github-actions

This comment has been minimized.

@ghost
Copy link

ghost commented Dec 2, 2021

@milkshakeuk I should be able to take a look this weekend.

@milkshakeuk milkshakeuk added this to the v3.1.0 milestone Dec 3, 2021
@ghost
Copy link

ghost commented Dec 5, 2021

Should CHANGELOG.md also be updated?

@milkshakeuk milkshakeuk force-pushed the ConcurrencyImprovements branch from 8444f41 to 09b0e34 Compare December 5, 2021 20:48
@github-actions
Copy link

github-actions bot commented Dec 5, 2021

Unit Test Results

       5 files     106 suites   24s ⏱️
1 051 tests 1 045 ✔️   6 💤 0 ❌
2 007 runs  1 996 ✔️ 11 💤 0 ❌

Results for commit 09b0e34.

@milkshakeuk
Copy link
Member Author

Should CHANGELOG.md also be updated?

I have updated it, I usually do this as prep for a new release but it shouldn't hurt to do it as we go along.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@ghost
Copy link

ghost commented Dec 5, 2021

Should CHANGELOG.md also be updated?

I have updated it, I usually do this as prep for a new release but it shouldn't hurt to do it as we go along.

Out of curiosity, when is the next release planned?

@milkshakeuk
Copy link
Member Author

@iangralinski-invetech I would like to port one more configuration from hapi before the next release, I don't suppose you would be interested, it's pretty small and some of the code already exists but is commented out in nHapi.

It's the UnexpectedSegmentBehaviour, there is already some commented out code in the MessageIterator ready to use the configuration/option, and here is the hapi implementation of its usage.

@milkshakeuk milkshakeuk merged commit 4c72955 into master Dec 6, 2021
@milkshakeuk milkshakeuk deleted the ConcurrencyImprovements branch December 7, 2021 15:04
@ghost
Copy link

ghost commented Dec 8, 2021

@milkshakeuk I could have a go at porting the UnexpectedSegmentBehaviour option from hapi, though I think I will only get the time to do so late this month, just before the end of the year.

@milkshakeuk
Copy link
Member Author

@iangralinski-invetech okay I might pick it up then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant