-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve concurrency issues #251
Conversation
a1818b3
to
8444f41
Compare
This comment has been minimized.
This comment has been minimized.
@milkshakeuk I should be able to take a look this weekend. |
Should |
8444f41
to
09b0e34
Compare
Unit Test Results 5 files 106 suites 24s ⏱️ Results for commit 09b0e34. |
I have updated it, I usually do this as prep for a new release but it shouldn't hurt to do it as we go along. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Out of curiosity, when is the next release planned? |
@iangralinski-invetech I would like to port one more configuration from hapi before the next release, I don't suppose you would be interested, it's pretty small and some of the code already exists but is commented out in nHapi. It's the UnexpectedSegmentBehaviour, there is already some commented out code in the MessageIterator ready to use the configuration/option, and here is the hapi implementation of its usage. |
@milkshakeuk I could have a go at porting the |
@iangralinski-invetech okay I might pick it up then. |
Improves on changes made in this commit;
@iangralinski-invetech Could you take a look also, if you get chance?