Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General house keeping (dependencies etc) #523

Merged
merged 6 commits into from
Dec 18, 2023
Merged

General house keeping (dependencies etc) #523

merged 6 commits into from
Dec 18, 2023

Conversation

milkshakeuk
Copy link
Member

@milkshakeuk milkshakeuk commented Dec 14, 2023 •
edited
Loading

  • Update the NUnit assertion model to the constraint model from the classic model which no longer receives updates.
  • Update some dependencies plus move to net8 SDK from net6
  • Update pipeline yaml to refer to target net462 and net8.0
  • Update CodeQL pipeline to use latest actions, plus fixed set-output warnings
  • Add Benchmark project
  • Update workflow to replace github-script download with download-artifact action
  • Run benchmarks as part of Pull Request
  • Add benchmark summary to job

@milkshakeuk
Update the NUnit assertion model to the contraint model from the clas…
bbc8a70 
…sic model which no longer receives updates.

- This also makes migrating to NUnit 4 easier.
- This enables Verify.NUnit to be updated to 22.1.4 since it depebnds on NUnit 4.
@milkshakeuk
Update some dependencies plus move to net8 SDK from net6
ea6705d
@milkshakeuk milkshakeuk requested a review from AMCN41R December 14, 2023 23:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

Unit Test Results

       5 files         5 suites   10s ⏱️
1 431 tests 1 343 ✔️   88 💤 0 ❌
2 692 runs  2 588 ✔️ 104 💤 0 ❌

Results for commit 7b3aa24.

♻️ This comment has been updated with latest results.

@milkshakeuk
update CodeQL pipeline to use latest actions, plus fixed set-output w…
4a31c06 
…arnings
@milkshakeuk
Add Benchmark project
79fad6a 
* update workflow actions to replace github-script download with download-artifact
* Run benchmarks as part of PR
* Add benchmark summary to job
@milkshakeuk
Copy link
Member Author

@AMCN41R could you have a look over this or if you get the chance?

@milkshakeuk
Fix PR review comments
7b3aa24 
- relative path instead of absolute + all verified txt files
- remove net462 preprocessor symbols from test
@milkshakeuk milkshakeuk merged commit b3933d4 into master Dec 18, 2023
13 checks passed
@milkshakeuk milkshakeuk deleted the GeneralHouseKeeping branch December 18, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMCN41R AMCN41R AMCN41R approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milkshakeuk @AMCN41R