Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inverted dependency synthesis #27

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

jfrconley
Copy link
Contributor

Problem

Synthesis throws an error when a stack references a cloudformation value from a yet-to-be converted stack

Solution

Use a singleton hook in prepareStack to ensure that all stacks are converted before other preparations take place

Test Plan:

  • Covered by existing tests
  • New coverage added
  • Special instructions for testing described below

Documentation:

  • No documentation required
  • Additional documentation required below

Additional Notes:

N/A

Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: dc33003

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nrfcloud/cdktf-aws-adaptor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jfrconley jfrconley requested review from apkostka and semcc July 8, 2024 22:33
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.91% 5424 / 6464
🔵 Statements 83.91% 5424 / 6464
🔵 Functions 70.5% 239 / 339
🔵 Branches 74.11% 484 / 653
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/core/cdk-adaptor-stack.ts 69.78% 78.88% 78% 69.78% 68-70, 93-94, 101-102, 114-115, 131-132, 299-300, 305-306, 315-316, 329-333, 369-374, 405, 420-421, 445-454, 458-465, 471-475, 478-487, 490-503, 509-526, 552-568, 593-596, 611-617, 625-628, 634-637, 649-650, 657-658, 661-662, 665-666, 704-705, 710-712, 715-722, 725-736, 739-744, 747-782, 785-787, 790-798, 801-809, 812-818, 821-827, 830-834, 837-839, 842-849
Generated in workflow #57

@jfrconley jfrconley merged commit 544d4bc into main Jul 9, 2024
5 checks passed
Copy link
Contributor

@apkostka apkostka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, weird bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants