-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common neutrino telescope alert schema #236
base: main
Are you sure you want to change the base?
Conversation
…Bronze track alerts
0 - initial 1 - update 1 2 - update 2...
@@ -0,0 +1,44 @@ | |||
{ | |||
"$id": "https://gcn.nasa.gov/schema/main/gcn/notices/neutrino_telescope/NeutrinoAlert.schema.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this should go in core or parallel to missions. We should be consistent with the proposed generic FRB schema (PR #217).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tied to this location, please advise. Easy to move now..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add it as gcn.notices.neutrino.alert.schema.json
Please advise on next steps to move this forward, thanks |
Hi @blaufuss, we decided to create a template folder alongside the core schema to host generic schema examples. |
thanks, Is this already in main? |
Soon will be, see PR: #243 |
I guess template means something. this is just a common unified schema. But I'm ok if that's where it should go. Please advise when this is merged to main and I will update my PR |
Sure, I will let you know. |
Hi @blaufuss , we discussed this in the GCN meeting. |
This is done |
"type": "object", | ||
"title": "IceCubeGoldAndBronzeTracks", | ||
"description": "IceCube Astrotrack Gold And Bronze track alert events", | ||
"allOf": [{ "$ref": "../neutrino/Alert.schema.json" }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jracusin and @lpsinger, is it fine to introduce an additional layer of schema?
File gcn/notices/neutrino/Alert.schema.json
consists of core schemas (such as Event.schema.json
and Alert.schema.json
) which are utilized for Icecube...
schema.
@blaufuss, this might add an extra layer of complexity for GCN. Since you are producer of gcn/notices/neutrino/Alert.schema.json
, we will request your approval for any changes in the core schemas, that would further be notified to the teams using this schema.
We would prefer the direct use of core.schema
. I misunderstood it as introducing new neutrino properties or example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit, I'm a bit confused. If there is a preferred method for implementing this, I'm very open
to suggestions, but I'm not understanding your concerns after the discussions we've had on this
and the month this has been posted.
Is there a better way to move this forward? I'm available to meet and discuss
Description
This PR adds a common GCN alert schema for alerts from neutrino telescopes.
It also reimplements the IceCube Gold/Bronze track alerts using this common schema, with example.
KM3Net will also implement their alerts using this common base schema.
We are happy to move the location of the shared base schema as determined by GCN dev team.