Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common neutrino telescope alert schema #236

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

blaufuss
Copy link
Contributor

Description

This PR adds a common GCN alert schema for alerts from neutrino telescopes.

It also reimplements the IceCube Gold/Bronze track alerts using this common schema, with example.

KM3Net will also implement their alerts using this common base schema.

We are happy to move the location of the shared base schema as determined by GCN dev team.

@@ -0,0 +1,44 @@
{
"$id": "https://gcn.nasa.gov/schema/main/gcn/notices/neutrino_telescope/NeutrinoAlert.schema.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should go in core or parallel to missions. We should be consistent with the proposed generic FRB schema (PR #217).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tied to this location, please advise. Easy to move now..

Copy link
Member

@Vidushi-GitHub Vidushi-GitHub Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it as gcn.notices.neutrino.alert.schema.json

@blaufuss
Copy link
Contributor Author

Please advise on next steps to move this forward, thanks

@Vidushi-GitHub
Copy link
Member

Hi @blaufuss, we decided to create a template folder alongside the core schema to host generic schema examples.

@Vidushi-GitHub Vidushi-GitHub self-requested a review February 10, 2025 05:11
@blaufuss
Copy link
Contributor Author

thanks, Is this already in main?

@Vidushi-GitHub
Copy link
Member

thanks, Is this already in main?

Soon will be, see PR: #243

@blaufuss
Copy link
Contributor Author

thanks, Is this already in main?

Soon will be, see PR: #243

I guess template means something. this is just a common unified schema. But I'm ok if that's where it should go. Please advise when this is merged to main and I will update my PR

@Vidushi-GitHub
Copy link
Member

Vidushi-GitHub commented Feb 13, 2025

thanks, Is this already in main?

Soon will be, see PR: #243

I guess template means something. this is just a common unified schema. But I'm ok if that's where it should go. Please advise when this is merged to main and I will update my PR

Sure, I will let you know.

@Vidushi-GitHub
Copy link
Member

Vidushi-GitHub commented Feb 18, 2025

Hi @blaufuss , we discussed this in the GCN meeting.
Please add a neutrino directory parallel to IceCube for the generic neutrino schema, and add it as gcn.notices.neutrino.alert.schema.json.

@blaufuss
Copy link
Contributor Author

Hi @blaufuss , we discussed this in the GCN meeting. Please add a neutrino directory parallel to IceCube for the generic neutrino schema, and add it as gcn.notices.neutrino.alert.schema.json.

This is done

"type": "object",
"title": "IceCubeGoldAndBronzeTracks",
"description": "IceCube Astrotrack Gold And Bronze track alert events",
"allOf": [{ "$ref": "../neutrino/Alert.schema.json" }],
Copy link
Member

@Vidushi-GitHub Vidushi-GitHub Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jracusin and @lpsinger, is it fine to introduce an additional layer of schema?
File gcn/notices/neutrino/Alert.schema.json consists of core schemas (such as Event.schema.json and Alert.schema.json) which are utilized for Icecube... schema.

@blaufuss, this might add an extra layer of complexity for GCN. Since you are producer of gcn/notices/neutrino/Alert.schema.json, we will request your approval for any changes in the core schemas, that would further be notified to the teams using this schema.
We would prefer the direct use of core.schema. I misunderstood it as introducing new neutrino properties or example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit, I'm a bit confused. If there is a preferred method for implementing this, I'm very open
to suggestions, but I'm not understanding your concerns after the discussions we've had on this
and the month this has been posted.

Is there a better way to move this forward? I'm available to meet and discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants