-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDSC-4327: Updates node, sass, bootstrap, and improves demo page. #127
Conversation
babel.config.js
Outdated
} | ||
} | ||
], | ||
'@babel/preset-react' | ||
], | ||
env: { | ||
test_cypress: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be reverted back to test: {
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 97.52% 97.53%
=======================================
Files 43 43
Lines 931 932 +1
Branches 226 226
=======================================
+ Hits 908 909 +1
Misses 23 23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one suggestion (typo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add notes to edsc update ticket
Co-authored-by: Ryan Abbott <[email protected]>
Styling issues observed during the demo were caused by my local Earthdata Search using Bootstrap 4, which does not contain |
Overview
What is the feature?
This PR updates a lot of libraries and improves constancy with other libraries.
What is the Solution?
node-sass
tosass
mini-css-extract-plugin
What areas of the application does this impact?
The whole library basically
Testing
Reproduction steps
Attachments
Checklist