Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4327: Updates node, sass, bootstrap, and improves demo page. #127

Merged
merged 11 commits into from
Jan 27, 2025

Conversation

trevorlang
Copy link
Contributor

@trevorlang trevorlang commented Jan 23, 2025

Overview

What is the feature?

This PR updates a lot of libraries and improves constancy with other libraries.

What is the Solution?

  • Updates node to v22
  • Moves from node-sass to sass
  • Temporarily silences sass deprecation warnings from bootstrap
  • Implements mini-css-extract-plugin
  • Updates bootstrap to v5
  • Tweaks the demo page
  • Adds github templates

What areas of the application does this impact?

The whole library basically

Testing

Reproduction steps

  1. Test the example application
  2. Test the echoforms library in Earthdata Search
  • There are known stying issues when installed in Earthdata Search due to the bootstrap version mismatch. These issues should be ignored when testing.

Attachments

image image

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have bumped the version field in package.json and ran npm install

babel.config.js Outdated
}
}
],
'@babel/preset-react'
],
env: {
test_cypress: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be reverted back to test: {

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.53%. Comparing base (1091550) to head (45dbf3b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Tree/TreeItem.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   97.52%   97.53%           
=======================================
  Files          43       43           
  Lines         931      932    +1     
  Branches      226      226           
=======================================
+ Hits          908      909    +1     
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abbottry abbottry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion (typo)

Copy link
Contributor Author

@trevorlang trevorlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add notes to edsc update ticket

Co-authored-by: Ryan Abbott <[email protected]>
@trevorlang
Copy link
Contributor Author

Styling issues observed during the demo were caused by my local Earthdata Search using Bootstrap 4, which does not contain .form-select. This is something that will get cleaned up when we update Earthdata Search to Bootstrap 5, alongside @edsc-echoforms.

@trevorlang trevorlang merged commit c2e721f into main Jan 27, 2025
8 checks passed
@trevorlang trevorlang deleted the EDSC-4327 branch January 27, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants