Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMT-3962: Added console log statements to help debug issue with login. #1336

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

cgokey
Copy link
Collaborator

@cgokey cgokey commented Jan 23, 2025

Overview

What is the feature?

Users can not login to MMT, adding console log statements to help debug.

What is the Solution?

Added console log statements

What areas of the application does this impact?

samlCallback and fetchEdlProfile

Testing

Look in cloudwatch for ***** in saml callback log statements

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (756d4b7) to head (d2acd6c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1336   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files         365      365           
  Lines        5762     5773   +11     
  Branches     1202     1213   +11     
=======================================
+ Hits         5629     5640   +11     
  Misses        132      132           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgokey cgokey merged commit 7d10ed7 into main Jan 23, 2025
7 checks passed
@cgokey cgokey deleted the MMT-3962 branch January 23, 2025 17:42
cgokey pushed a commit that referenced this pull request Jan 23, 2025
cgokey added a commit that referenced this pull request Jan 30, 2025
…th login. (#1336)" (#1337)

This reverts commit 7d10ed7.

Co-authored-by: Christopher Gokey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants