feat: add wait_until flag, drop check_tx method #136

telezhnaya · 2024-01-11T14:45:50Z

Updated the code to match with 1.37 nearcore release
https://github.com/near/nearcore/blob/447572bb775a5954ca7a5a4b65c85b45aab9e499/chain/jsonrpc/CHANGELOG.md#023
TLDR:

dropped EXPERIMENTAL_check_tx method, we won't support it anymore
added support of new send_tx method
added example for send_tx
added support for wait_until flag to few places

We need to merge it only after 1.37 will be released

frol

@telezhnaya Thank you for contributing it ahead of time!!!

examples/query_tx.rs

miraclx

lgtm ✨

src/methods/send_tx.rs

miraclx · 2024-01-11T14:59:50Z

examples/send_tx.rs

+    let signer_account_id = utils::input("Enter the signer Account ID: ")?.parse()?;
+    let signer_secret_key = utils::input("Enter the signer's private key: ")?.parse()?;
+    let wait_until_str = utils::input("Enter the desired guaranteed execution status: ")?;
+    let wait_until = serde_json::from_str(&("\"".to_owned() + &wait_until_str + "\""))?;


btw, this can be simplified:

Suggested change

let wait_until = serde_json::from_str(&("\"".to_owned() + &wait_until_str + "\""))?;

let wait_until = serde_json::from_value(json!(wait_until_str))?;

Unfortunately, it's not true.
I also need to put my str into quotes to create a valid json. With adding quotes, your option is the same as mine.

@telezhnaya Are you sure you tried from_value (not from_str) and pass json!(value) instead of String value? This code should work as far as I can tell.

value should be a valid json in json!(value). If it's string, it should be quoted.

@telezhnaya This is what we meant here: a4f27a4

telezhnaya · 2024-01-16T14:58:28Z

The only failing test fails because it really sends RPC request to mainnet which is not upgraded yet (so, the method does not work as we expect).

examples/create_account.rs

telezhnaya · 2024-01-29T22:11:50Z

Updated. As before, one of the tests fails because mainnet and testnet still has 1.36, waiting for the release

khorolets · 2024-02-15T11:56:15Z

I am curious about the best approach to releasing this soon. With the ReadRPC project, we are working on a version compatible with 1.37.x nearcore that is already run on testnet. We use near-jsonrpc-client-rs heavily and would like to run on the released version rather than fork.

And for the future, we'd like to be able to use newer versions of the client before the nearcore update on the mainnet. Do you think we can adjust the release process of this crate somehow?

cc @frol @telezhnaya @kobayurii

khorolets · 2024-02-26T08:09:13Z

Update:

We've agreed with the change on the nearcore release process to enable release candidates (RC) for the nearcore's workspace crates. Since the next testnet release we expect to have all the crates like near-jsonrpc-primitives, near-primitives and others to be released with the same *-rc.{\d} as nearcore.

The mainnet 1.37.0 release is anticipated this week, so we're not getting the necessary crates beforehand this time, but the next time it should be available 🎉

frol · 2024-03-11T18:17:35Z

Status update: blocked on https://near.zulipchat.com/#narrow/stream/295302-general/topic/publishing.20nearcore.20crates/near/425971002

jaswinder6991 · 2024-04-18T15:33:53Z

Are there any new changes needed here other than just running the CI again?
I can help if anything, we needed this merged for a project.

frol · 2024-04-18T22:34:33Z

I will re-open this PR to trigger CI

jaswinder6991 · 2024-04-19T03:23:43Z

Thanks Vlad, I can see that doc tests failed again. I made a PR to wait_until branch to fix this.
#139

As an aside, I see that you fixed it a month ago as well. Does the archival node only keep a months old data? or is it failing because of some other reason.
Would it be a good idea to change the test somehow rather than fixing it every month (not a big deal though but still)

…ock)

telezhnaya requested a review from miraclx January 11, 2024 14:46

frol approved these changes Jan 11, 2024

View reviewed changes

examples/query_tx.rs Outdated Show resolved Hide resolved

miraclx approved these changes Jan 11, 2024

View reviewed changes

src/methods/send_tx.rs Outdated Show resolved Hide resolved

miraclx reviewed Jan 11, 2024

View reviewed changes

telezhnaya force-pushed the telezhnaya/wait_until branch from 615021f to e92e6f8 Compare January 16, 2024 13:34

telezhnaya mentioned this pull request Jan 16, 2024

🔷 [ProjectTracking] RPC API improvements near/nearcore#10047

Closed

frol reviewed Jan 20, 2024

View reviewed changes

examples/create_account.rs Outdated Show resolved Hide resolved

telezhnaya force-pushed the telezhnaya/wait_until branch 3 times, most recently from 599369b to ddc30f0 Compare January 29, 2024 22:08

feat: add wait_until flag, drop check_tx method

781fa5d

telezhnaya force-pushed the telezhnaya/wait_until branch from ddc30f0 to 781fa5d Compare January 29, 2024 22:10

refactor: use serde_json::from_value

a4f27a4

bumped nearcore crate versions

fa4e56f

frol added 2 commits March 11, 2024 20:14

bumped nearcore crate versions

e2fe261

fixed doc-test

0fc86d9

anthony-near mentioned this pull request Mar 25, 2024

use wait_until optional param when calling jsonrpc-client near/pagoda-relayer-rs#68

Closed

frol closed this Apr 18, 2024

frol reopened this Apr 18, 2024

frol enabled auto-merge (squash) April 18, 2024 22:36

fixed validators_ordered test (updated block hash to a more recent bl…

e2e7a5e

…ock)

frol merged commit 2b4ad7b into master Apr 19, 2024
3 checks passed

frol deleted the telezhnaya/wait_until branch April 19, 2024 13:11

frol mentioned this pull request Apr 19, 2024

chore: release v0.9.0 #140

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add wait_until flag, drop check_tx method #136

feat: add wait_until flag, drop check_tx method #136

telezhnaya commented Jan 11, 2024 •

edited

Loading

frol left a comment

miraclx left a comment

miraclx Jan 11, 2024 •

edited

Loading

telezhnaya Jan 16, 2024

frol Jan 20, 2024

telezhnaya Jan 23, 2024

frol Feb 4, 2024

telezhnaya commented Jan 16, 2024

telezhnaya commented Jan 29, 2024

khorolets commented Feb 15, 2024

khorolets commented Feb 26, 2024

frol commented Mar 11, 2024

jaswinder6991 commented Apr 18, 2024

frol commented Apr 18, 2024

jaswinder6991 commented Apr 19, 2024 •

edited

Loading

	let wait_until = serde_json::from_str(&("\"".to_owned() + &wait_until_str + "\""))?;
	let wait_until = serde_json::from_value(json!(wait_until_str))?;

feat: add wait_until flag, drop check_tx method #136

feat: add wait_until flag, drop check_tx method #136

Conversation

telezhnaya commented Jan 11, 2024 • edited Loading

frol left a comment

Choose a reason for hiding this comment

miraclx left a comment

Choose a reason for hiding this comment

miraclx Jan 11, 2024 • edited Loading

Choose a reason for hiding this comment

telezhnaya Jan 16, 2024

Choose a reason for hiding this comment

frol Jan 20, 2024

Choose a reason for hiding this comment

telezhnaya Jan 23, 2024

Choose a reason for hiding this comment

frol Feb 4, 2024

Choose a reason for hiding this comment

telezhnaya commented Jan 16, 2024

telezhnaya commented Jan 29, 2024

khorolets commented Feb 15, 2024

khorolets commented Feb 26, 2024

frol commented Mar 11, 2024

jaswinder6991 commented Apr 18, 2024

frol commented Apr 18, 2024

jaswinder6991 commented Apr 19, 2024 • edited Loading

telezhnaya commented Jan 11, 2024 •

edited

Loading

miraclx Jan 11, 2024 •

edited

Loading

jaswinder6991 commented Apr 19, 2024 •

edited

Loading