Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debug-ui): extend epoch info api #12891

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Longarithm
Copy link
Member

@Longarithm Longarithm commented Feb 7, 2025

Allows to query arbitrary epoch by id in the epoch validators page.
The interface allows to either input id or scroll back and forth between epochs.

The main caveat is:

  • current epoch must be indexed by ValidatorInfoIdentifier::BlockHash because it wasn't finalised yet and it is a sign that its stats are being updated online;
  • for past epochs we must use ValidatorInfoIdentifier::EpochId because BlockInfo data used for block navigation may be GC-d.

Other small fixes:

  • Support NotEnoughChunkEndorsements kickout reason
  • Display kickout among the roles for the next epoch because that's where it actually comes in place. Displaying it for the current epoch is confusing.

See video preview here https://near.zulipchat.com/#narrow/channel/295558-core/topic/Optimistic.20Block.20Design/near/498834846

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 3.70370% with 156 lines in your changes missing coverage. Please review.

Project coverage is 70.49%. Comparing base (8b3fc09) to head (ea3511c).

Files with missing lines Patch % Lines
chain/client/src/debug.rs 0.00% 131 Missing ⚠️
chain/jsonrpc/src/lib.rs 19.35% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12891      +/-   ##
==========================================
- Coverage   70.54%   70.49%   -0.05%     
==========================================
  Files         851      851              
  Lines      174983   175049      +66     
  Branches   174983   175049      +66     
==========================================
- Hits       123433   123401      -32     
- Misses      46419    46513      +94     
- Partials     5131     5135       +4     
Flag Coverage Δ
backward-compatibility 0.36% <0.00%> (-0.01%) ⬇️
db-migration 0.36% <0.00%> (-0.01%) ⬇️
genesis-check 1.42% <0.00%> (-0.01%) ⬇️
linux 70.33% <3.70%> (-0.04%) ⬇️
linux-nightly 70.14% <3.70%> (-0.04%) ⬇️
pytests 1.73% <0.00%> (-0.01%) ⬇️
sanity-checks 1.54% <0.00%> (-0.01%) ⬇️
unittests 70.32% <3.70%> (-0.05%) ⬇️
upgradability 0.36% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Longarithm Longarithm force-pushed the es-button branch 2 times, most recently from f1a3d05 to f39da0f Compare February 11, 2025 10:59
@Longarithm Longarithm changed the title wip: debug ui arbitrary epoch validators feat(debug-ui): extend epoch info api Feb 14, 2025
@Longarithm Longarithm marked this pull request as ready for review February 14, 2025 11:53
@Longarithm Longarithm requested a review from a team as a code owner February 14, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant