Skip to content

Commit

Permalink
Collapse the "create empty" section on test snapshot
Browse files Browse the repository at this point in the history 
to avoid jitter
  • Loading branch information
@krassowski
krassowski committed May 7, 2024
1 parent f35b769 commit 79d3d47
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ui-tests/tests/jupyterlab_new_launcher.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ test.describe('With starred section', () => {
.locator('.jp-Launcher-launchNotebook .jp-starIconButton')
.click();
await page.locator('.jp-Launcher-launchConsole .jp-starIconButton').click();
// collapse the "create empty" section
await page.locator('.jp-Launcher-openByType summary').click();
expect(await launcher.screenshot()).toMatchSnapshot(

Check failure on line 34 in ui-tests/tests/jupyterlab_new_launcher.spec.ts

View workflow job for this annotation

GitHub Actions / Integration tests

tests/jupyterlab_new_launcher.spec.ts:23:7 › With starred section › should render new launcher with starred section 

  1) tests/jupyterlab_new_launcher.spec.ts:23:7 › With starred section › should render new launcher with starred section 
    Error: Screenshot comparison failed:

      24757 pixels (ratio 0.06 of all image pixels) are different.

    Expected: /home/runner/work/jupyterlab-new-launcher/jupyterlab-new-launcher/ui-tests/tests/jupyterlab_new_launcher.spec.ts-snapshots/launcher-with-starred-linux.png
    Received: /home/runner/work/jupyterlab-new-launcher/jupyterlab-new-launcher/ui-tests/test-results/tests-jupyterlab_new_launc-99976-uncher-with-starred-section/launcher-with-starred-actual.png
        Diff: /home/runner/work/jupyterlab-new-launcher/jupyterlab-new-launcher/ui-tests/test-results/tests-jupyterlab_new_launc-99976-uncher-with-starred-section/launcher-with-starred-diff.png


      32 |     // collapse the "create empty" section
      33 |     await page.locator('.jp-Launcher-openByType summary').click();
    > 34 |     expect(await launcher.screenshot()).toMatchSnapshot(
         |                                         ^
      35 |       'launcher-with-starred.png'
      36 |     );
      37 |   });

        at /home/runner/work/jupyterlab-new-launcher/jupyterlab-new-launcher/ui-tests/tests/jupyterlab_new_launcher.spec.ts:34:41
'launcher-with-starred.png'
);
Expand Down

0 comments on commit 79d3d47

Please sign in to comment.