Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to customize keycloak themes #2469

Merged
merged 10 commits into from
Mar 4, 2025
Merged

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented May 16, 2024

Reference Issues or PRs

closes #1980

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR:

Any other comments?

@viniciusdc viniciusdc marked this pull request as ready for review May 30, 2024 15:20
@viniciusdc viniciusdc changed the title Add option to customize keycloak themes [WIP] Add option to customize keycloak themes May 30, 2024
@viniciusdc
Copy link
Contributor Author

This issue has been on my plate since Qhub and we've wanted to address it for a while, but I only recently migrated it to the current source code.

@viniciusdc
Copy link
Contributor Author

How to test this PR:

@marcelovilla
Copy link
Member

@viniciusdc is this ready for review? If yes, let me know and I'll test so we can merge it!

@viniciusdc viniciusdc added the needs: review 👀 This PR is complete and ready for reviewing label Aug 16, 2024
@viniciusdc
Copy link
Contributor Author

Hi @marcelovilla yes this is ready for review, I still need to open a doc PR for this, but in the meantime if you can test, that would be nice

@marcelovilla
Copy link
Member

@viniciusdc sorry that I haven't gotten around to test this PR but I'll do that between today and tomorrow

@marcelovilla marcelovilla self-requested a review October 29, 2024 09:36
@marcelovilla marcelovilla self-assigned this Feb 25, 2025
@marcelovilla marcelovilla requested a review from a team as a code owner March 3, 2025 21:08
@marcelovilla marcelovilla requested review from dcmcand and removed request for a team March 3, 2025 21:08
Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it with a custom theme and it works perfectly 🚀, thanks @viniciusdc!

@marcelovilla marcelovilla added this to the 2025.3.1 release milestone Mar 4, 2025
@viniciusdc viniciusdc merged commit fde02bf into main Mar 4, 2025
26 checks passed
@viniciusdc viniciusdc deleted the keycloak-themes-update branch March 4, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[ENH] Keycloak theme customization
2 participants