extra fixes SpaceAssignmentRule: handle scenario where group method c…

…an belong to non gradle classes
nebula-plugins · Jan 25, 2025 · f296a88 · f296a88
1 parent 468026d
commit f296a88
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/main/groovy/com/netflix/nebula/lint/rule/dsl/SpaceAssignmentRule.groovy b/src/main/groovy/com/netflix/nebula/lint/rule/dsl/SpaceAssignmentRule.groovy
@@ -56,8 +56,7 @@ class SpaceAssignmentRule extends ModelAwareGradleLintRule {
         return dslStack().empty ||
                 dslStack().containsAll(['subprojects']) ||
                 dslStack().containsAll(['allprojects']) ||
-                dslStack().contains('configureEach') ||
-                dslStack().contains('tasks')
+                dslStack().contains('configureEach')
     }
 
     private void addViolation(MethodCallExpression call) {

diff --git a/src/test/groovy/com/netflix/nebula/lint/rule/dsl/SpaceAssignmentRuleSpec.groovy b/src/test/groovy/com/netflix/nebula/lint/rule/dsl/SpaceAssignmentRuleSpec.groovy
@@ -58,6 +58,13 @@ class SpaceAssignmentRuleSpec extends BaseIntegrationTestKitSpec {
             if (matcher.find()) {
                 def x = matcher.group(1).replace(".", "/")
             }
+            tasks.register('hello') {
+              doLast {
+                    if (matcher.find()) {
+                    def x = matcher.group(1).replace(".", "/")
+                }
+              }
+            }            
         """
 
         when: