This repository has been archived by the owner on Mar 11, 2022. It is now read-only.
Fix a few warnings on Xcode 10 #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be worth trying a Travis CI build with Xcode 10 - if that works then we could merge this without fear of breaking the CI builds. |
|
Yeah this is broken. Will check later today |
|
! https://travis-ci.com/aaronraimist/seaglass/jobs/146814341 Alright that works, if you are comfortable using a beta version of CocoaPods |
neilalexander
force-pushed
the
master
branch
from
e56d9f9 to
f5405e4
Compare
aaronraimist
force-pushed
the
whole-module
branch
from
f946dc5 to
4aef6d7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns on whole module optimization for pods: https://stackoverflow.com/questions/46722323/project-pods-turn-on-whole-module-optimization
Turns on Automatically Select Architectures for several Pods. Not sure if this is an Xcode 10 only feature or not. I didn't see these warnings in Xcode 9.
Using Xcode 10 also seems to require a pre-release version of Cocoapods for now so you may not want to merge this yet.