Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Netlify Image CDN #2421

Draft
wants to merge 4 commits into
base: v4
Choose a base branch
from
Draft

feat: support Netlify Image CDN #2421

wants to merge 4 commits into from

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Feb 8, 2024

Description

Documentation

Tests

You can test this change yourself like so:

  1. TODO

Relevant links (GitHub issues, etc.) or a picture of cute animal

This comment was marked as outdated.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 9a2b8ff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/65cba4af31ea3b000840e7c8
😎 Deploy Preview https://deploy-preview-2421--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This comment was marked as outdated.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Feb 8, 2024
@@ -15,7 +15,6 @@
"@netlify/blobs": "^2.2.0",
"@netlify/esbuild": "0.14.39",
"@netlify/functions": "^1.6.0",
"@netlify/ipx": "^1.4.6",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bye bye

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 Hurrah! 🎉

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 9a2b8ff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/65cba4afda6a0200088ee24e
😎 Deploy Preview https://deploy-preview-2421--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 9a2b8ff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/65cba4af6d37db00085b982f
😎 Deploy Preview https://deploy-preview-2421--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 9a2b8ff
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/65cba4af4185420008b08a61
😎 Deploy Preview https://deploy-preview-2421--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 9a2b8ff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/65cba4af9a0ba90008eb0d36
😎 Deploy Preview https://deploy-preview-2421--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for netlify-plugin-nextjs-demo-all-flags ready!

Name Link
🔨 Latest commit 9a2b8ff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo-all-flags/deploys/65cba4afa5bf37000848d4cc
😎 Deploy Preview https://deploy-preview-2421--netlify-plugin-nextjs-demo-all-flags.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 9a2b8ff
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/65cba4af8eeb830008be716a
😎 Deploy Preview https://deploy-preview-2421--next-plugin-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 9a2b8ff
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/65cba4af6dd0650008658ecf
😎 Deploy Preview https://deploy-preview-2421--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 9a2b8ff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/65cba4af31ea3b000840e7c6
😎 Deploy Preview https://deploy-preview-2421--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 9a2b8ff
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/65cba4af3b713900083c8250
😎 Deploy Preview https://deploy-preview-2421--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@serhalp
Copy link
Contributor

serhalp commented Jun 4, 2024

Superseded by v5.

@serhalp serhalp closed this Jun 4, 2024
@serhalp serhalp deleted the image-cdn branch June 4, 2024 15:32
@ascorbic
Copy link
Contributor Author

ascorbic commented Jun 5, 2024

@serhalp This was specifically to enable it for the legacy adapter so we can deprecate netlify/ipx for old versions too

@serhalp
Copy link
Contributor

serhalp commented Jun 5, 2024

@ascorbic But is that something we plan on doing?

@ascorbic
Copy link
Contributor Author

ascorbic commented Jun 6, 2024

It was. This was blocked because of the issue with image CDN not working with private sources, but that's no longer the case. I think it would be worth doing this backport if possible.

@serhalp serhalp restored the image-cdn branch June 6, 2024 12:10
@serhalp serhalp reopened this Jun 6, 2024
@serhalp serhalp added the v4 Issues related to the v4 Next.js runtime label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality v4 Issues related to the v4 Next.js runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants