Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra to report in summary if needed #29

Merged
merged 1 commit into from
Sep 26, 2024
Merged

add extra to report in summary if needed #29

merged 1 commit into from
Sep 26, 2024

Conversation

dhuangnm
Copy link
Member

Summary:

Add extra input argument to the report test action so that more info can be reported if needed.

Test Plan:

All.

@derekk-nm
Copy link
Contributor

Why do this? you can add the information as a separate line of text, or any markdown content, to $GITHUB_STEP_SUMMARY. it doesn't need to be included in the table.

@derekk-nm
Copy link
Contributor

derekk-nm commented Sep 26, 2024

I think a better way to do this would be a refactor of the action to accept a dict, or list of tuples, of label/value pairs and build the table w/ that info. I've entered an Asana ticket "refactor actions/summary-test/action.yml to accept dict of table entries" for this recommendation.

@dhuangnm dhuangnm added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 7fdc658 Sep 26, 2024
1 check passed
@dhuangnm dhuangnm deleted the extra branch September 26, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants