Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle an error inside parseProviders() when providerId not found in config #12438

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

KostyaTretyak
Copy link
Contributor

☕️ Reasoning

Currently, if an invalid providerId is entered, the parseProviders() function will return an empty provider. I discovered this when I intentionally entered an incorrect providerId in the url curl -iS http://0.0.0.0:3000/auth/callback/providerType -d '' so that the error handler would tell me what to enter. Instead, it throws the following error:

TypeError: Cannot read properties of undefined (reading 'type')

Error stack pointing to this row:

if (options.provider.type === "credentials")

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

Copy link

vercel bot commented Dec 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 11:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2024 11:05pm

Copy link

vercel bot commented Dec 29, 2024

@KostyaTretyak is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! But maybe in a follow-up PR, could you add a custom error in here?: https://github.com/nextauthjs/next-auth/blob/main/packages/core/src/errors.ts

@balazsorban44 balazsorban44 merged commit 80a2c14 into nextauthjs:main Jan 7, 2025
3 of 4 checks passed
@KostyaTretyak
Copy link
Contributor Author

Okay. I will try at the next opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants