Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collabora: allow to configure additional options #6085

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Feb 25, 2025
@szaimen szaimen added this to the next milestone Feb 25, 2025
@szaimen szaimen force-pushed the enh/noid/collabora-additional-options branch 4 times, most recently from 7aaad90 to f117673 Compare February 25, 2025 10:48
@szaimen szaimen marked this pull request as ready for review February 25, 2025 10:49
@szaimen szaimen force-pushed the enh/noid/collabora-additional-options branch 7 times, most recently from 029377e to b3482e2 Compare February 26, 2025 12:42
@szaimen szaimen force-pushed the enh/noid/collabora-additional-options branch from b3482e2 to 4e84080 Compare February 26, 2025 13:31
@szaimen szaimen requested a review from st3iny February 26, 2025 13:39
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested three cases: an empty value, the inline (JSON) array syntax ([...]) and the multi-line (YAML) array syntax (- ...).

@szaimen szaimen requested a review from st3iny February 27, 2025 10:43
Signed-off-by: Simon L. <[email protected]>
@szaimen szaimen force-pushed the enh/noid/collabora-additional-options branch from 47156b8 to d01dc6a Compare February 27, 2025 10:52
@szaimen szaimen requested a review from st3iny February 27, 2025 10:53
@szaimen
Copy link
Collaborator Author

szaimen commented Feb 27, 2025

Thanks for the review and approval Richard! ☺️

@szaimen szaimen merged commit c5c1912 into main Feb 27, 2025
9 checks passed
@szaimen szaimen deleted the enh/noid/collabora-additional-options branch February 27, 2025 11:40
@szaimen
Copy link
Collaborator Author

szaimen commented Feb 28, 2025

This is now released with v10.7.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants