support clamav on aarch64/arm64 by using the alpine package #6094
Conversation
Zoey2936
force-pushed
the
clamav-alpine-aarch64
branch
2 times, most recently
from
e56fee0 to
576298f
Compare
Signed-off-by: Zoey <[email protected]>
Zoey2936
force-pushed
the
clamav-alpine-aarch64
branch
from
576298f to
5cadc7b
Compare
|
the only downside I see is that the alpine package may be a bit oudated compared to the direct image |
|
Hi @Zoey2936, first of all thanks a lot for the PR! |
this is fine for me |
Indeed. Would you mind adjusting the PR or shall I? |
| freshclam --foreground --stdout --daemon & | ||
| clamd --foreground --config-file=/tmp/clamd.conf |
There was a problem hiding this comment.
Shouldnt we better use supervisord for that? Then it will make sure to automatically restart both services if they should be stopped :)
There was a problem hiding this comment.
Thats how it is done in the start script of the official clamav image, but yes, feel free to edit this PR
can you please do this? Thanks! |
Containers/clamav/start.sh
Outdated
| if ! freshclam --foreground --stdout; then | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
this could also run inside the Dockerfile, which would make the docker image bigger, but the container may starts faster depending on the internet speed it has, but the pull would take longer.
This is needed to download the initial databases which will be updated by the freshclam deamon while running.
There was a problem hiding this comment.
This is a very good idea! :)
There was a problem hiding this comment.
what exactly? both is reasonable
There was a problem hiding this comment.
I mean to run it in the Dockerfile already :)
| mkdir /run/clamav && \ | ||
| chmod 777 -R /run/clamav /var/log/clamav && \ | ||
| sed -i "s|#\?MaxDirectoryRecursion.*|MaxDirectoryRecursion 30|g" /etc/clamav/clamd.conf && \ | ||
| sed -i "s|#\?MaxFileSize.*|MaxFileSize 2G|g" /etc/clamav/clamd.conf && \ |
There was a problem hiding this comment.
| sed -i "s|#\?MaxFileSize.*|MaxFileSize 2G|g" /etc/clamav/clamd.conf && \ | |
| sed -i "s|#\?MaxFileSize.*|MaxFileSize aio-placeholder|g" /etc/clamav/clamd.conf && \ |
There was a problem hiding this comment.
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
No description provided.