feat: add example contact on first login #50156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza221
added
enhancement
3. to review
st3iny
reviewed
Jan 21, 2025
hamza221
force-pushed
the
feat/cardav-example-contact
branch
from
b237d7a to
3af4fc4
Compare
hamza221
added
2. developing
st3iny
reviewed
Jan 23, 2025
st3iny
reviewed
Jan 23, 2025
3 tasks
hamza221
force-pushed
the
feat/cardav-example-contact
branch
from
9101f07 to
979db68
Compare
3 tasks
st3iny
added
3. to review
hamza221
force-pushed
the
feat/cardav-example-contact
branch
from
b6cd5b0 to
3c3150b
Compare
Signed-off-by: Hamza Mahjoubi <[email protected]>
hamza221
force-pushed
the
feat/cardav-example-contact
branch
from
3c3150b to
85f8d9f
Compare
|
|
||
| public function getForm(): TemplateResponse { | ||
| $enableDefaultContact = $this->config->getAppValue(Application::APP_ID, 'enableDefaultContact', 'no'); | ||
| $this->initialState->provideInitialState('enableDefaultContact', $enableDefaultContact); |
There was a problem hiding this comment.
This is a code smell. Without looking at the method body of getForm, I wouldn't expect the method to have a side effect of filling an initial state. Try to move that out of the method, or rename the method.
There was a problem hiding this comment.
I agree, but it is commonly used across Nextcloud code base for this same purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist