[WIP] feat: default contact #4301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hamza Mahjoubi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4301 +/- ##
============================================
- Coverage 11.15% 10.98% -0.17%
- Complexity 265 276 +11
============================================
Files 121 123 +2
Lines 5533 5633 +100
Branches 1196 1215 +19
============================================
+ Hits 617 619 +2
- Misses 4794 4892 +98
Partials 122 122 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hamza Mahjoubi <[email protected]>
4 tasks
Signed-off-by: Hamza Mahjoubi <[email protected]>
hamza221
added
enhancement
hamza221
requested review from
SebastianKrupinski and
GVodyanov
as code owners
Signed-off-by: Hamza Mahjoubi <[email protected]>
st3iny
reviewed
Jan 21, 2025
| type="checkbox" | ||
| class="checkbox" | ||
| @change="updateEnableDefaultContact"> | ||
| <label for="enable-default-contact"> {{ t('mail',"Default contact is added to the user's own address book on user's first login.") }} </label> |
There was a problem hiding this comment.
Suggested change
| <label for="enable-default-contact"> {{ t('mail',"Default contact is added to the user's own address book on user's first login.") }} </label> | |
| <label for="enable-default-contact"> {{ t('contacts', "Default contact is added to the user's own address book on user's first login.") }} </label> |
|
Moved to nextcloud/server#50156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4289