Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(circles): sort fallback if not member of circle #3809

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

skjnldsv
Copy link
Member

Before After
2024-02-16_12-34 2024-02-16_12-33

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews feature: circles labels Feb 16, 2024
@skjnldsv skjnldsv self-assigned this Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1a8cd22) 2.12% compared to head (05f04df) 2.49%.

Files Patch % Lines
src/components/AppNavigation/RootNavigation.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3809      +/-   ##
==========================================
+ Coverage     2.12%   2.49%   +0.37%     
==========================================
  Files          114      90      -24     
  Lines         5221    4441     -780     
  Branches      1130    1132       +2     
==========================================
  Hits           111     111              
+ Misses        4990    4210     -780     
  Partials       120     120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst
Copy link
Member

/backport to stable5.5

@ChristophWurst ChristophWurst merged commit 84d5b94 into main Feb 16, 2024
23 of 24 checks passed
@ChristophWurst ChristophWurst deleted the fix/circles-sort branch February 16, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: circles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants