Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPDX header #3947

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Add SPDX header #3947

merged 4 commits into from
Jun 4, 2024

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented May 30, 2024 •
edited
Loading

  • Adding SPDX headers
  • Adding a GH action to check for compliance
  • Adding a status badge for REUSE compliance
  • Replaced most icons with current Material Design ones
  • Replaced most logos when available with the originals

@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdx branch 7 times, most recently from 342d557 to 7ede660 Compare June 4, 2024 16:27
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 4, 2024
@AndyScherzinger AndyScherzinger marked this pull request as ready for review June 4, 2024 16:32
@AndyScherzinger AndyScherzinger requested a review from hamza221 as a code owner June 4, 2024 16:32
@AndyScherzinger AndyScherzinger added this to the v6.1.0 milestone Jun 4, 2024
ChristophWurst
ChristophWurst reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave the unrelated workflow bumps to renovate

.github/workflows/appstore-build-publish.yml Outdated Show resolved Hide resolved
.github/workflows/lint-php.yml Outdated Show resolved Hide resolved
st3iny
st3iny approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy 🚀

@AndyScherzinger
chore: Add SPDX header
c54f876 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
ci: Add REUSE check
fd28954 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
docs: Add REUSE status badge
448f528 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
chore: removed language icon reference - replaced with material desig…
17ca797 
…n and SPDX info

Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger merged commit 4a18785 into main Jun 4, 2024
25 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/spdx branch June 4, 2024 18:21
@welcome Welcome
Copy link

welcome bot commented Jun 4, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@AndyScherzinger
Copy link
Member Author

Thanks for the reviews 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@st3iny st3iny st3iny approved these changes

@hamza221 hamza221 hamza221 approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
v6.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AndyScherzinger @ChristophWurst @st3iny @hamza221