Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove app-content-details from global styling #4302

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jan 20, 2025

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.13%. Comparing base (84abda7) to head (12707c4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4302      +/-   ##
============================================
- Coverage     11.15%   11.13%   -0.02%     
  Complexity      265      265              
============================================
  Files           121      121              
  Lines          5533     5542       +9     
  Branches       1196     1200       +4     
============================================
  Hits            617      617              
- Misses         4794     4803       +9     
  Partials        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD added the 3. to review Waiting for reviews label Jan 20, 2025
@GretaD GretaD requested a review from hamza221 January 20, 2025 19:55
src/components/CircleDetails.vue Outdated Show resolved Hide resolved
src/css/contacts.scss Outdated Show resolved Hide resolved
@GretaD GretaD requested a review from st3iny January 21, 2025 10:10
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash and we are good to go.

@st3iny
Copy link
Member

st3iny commented Jan 21, 2025

Also stylelint has something to say:

src/css/contacts.scss
  21:1  ✖  Expected empty line before rule  rule-empty-line-before

I think you need an empty line before the line: .app-contacts {

@GretaD GretaD force-pushed the fix/app-content-details-globaly branch from 0d41754 to 12707c4 Compare January 21, 2025 10:39
@st3iny st3iny merged commit 36c9078 into main Jan 21, 2025
33 of 34 checks passed
@st3iny st3iny deleted the fix/app-content-details-globaly branch January 21, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emails escape the message element
2 participants