Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make circle members visible again by moving them out of the modal #4334

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 7, 2025

As discussed between @sorbaugh and @jancborchardt this moves the team member list out of the modal and onto the team page again.

Screenshot 2025-02-07 at 09 58 57

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 11.16%. Comparing base (e497f03) to head (6238a71).

Files with missing lines Patch % Lines
src/components/MemberList.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4334      +/-   ##
============================================
+ Coverage     11.12%   11.16%   +0.04%     
  Complexity      265      265              
============================================
  Files           121      121              
  Lines          5545     5525      -20     
  Branches       1201     1192       -9     
============================================
  Hits            617      617              
+ Misses         4806     4786      -20     
  Partials        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Feb 7, 2025
@juliusknorr
Copy link
Member Author

I'm stuggling with a bug that is also there on main but would be good to address with this one as it is quite noticable:

When adding a new member it is not showing up immediately in the list, is suspect some vue/vuex reactivity issue but could not figure out why the list does not update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant