Skip to content

Commit

Permalink
New Bui8ld 2.19.2
Browse files Browse the repository at this point in the history
  • Loading branch information
Marino Faggiana authored and Marino Faggiana committed Feb 5, 2018
1 parent 62dfb11 commit c2f77c6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions iOSClient/Brand/PickerFileProvider.plist
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
<key>CFBundlePackageType</key>
<string>XPC!</string>
<key>CFBundleShortVersionString</key>
<string>2.19.1</string>
<string>2.19.2</string>
<key>CFBundleVersion</key>
<string>00002</string>
<string>00021</string>
<key>NSExtension</key>
<dict>
<key>NSExtensionFileProviderDocumentGroup</key>
Expand Down
4 changes: 2 additions & 2 deletions iOSClient/Brand/iOSClient.plist
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>2.19.1</string>
<string>2.19.2</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand All @@ -69,7 +69,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>00002</string>
<string>00021</string>
<key>Fabric</key>
<dict>
<key>APIKey</key>
Expand Down
4 changes: 2 additions & 2 deletions iOSClient/Utility/CCError.m
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ + (NSString *)manageErrorKCF:(NSInteger)errorCode withNumberError:(BOOL)withNumb
case 404: // 404 Not Found. When for example we try to access a path that now not exist
return NSLocalizedStringFromTable(@"_error_path_", @"Error", nil);
break;
case 423: // 423 WebDAV Locked: Trying to access locked resource
return NSLocalizedStringFromTable(@"WebDAV Locked: Trying to access locked resource", @"Error", nil);
case 423: // 423 WebDAV Locked : The resource that is being accessed is locked
return NSLocalizedStringFromTable(@"_webdav_locked_", @"Error", nil);
break;
case 500:
return NSLocalizedStringFromTable(@"_internal_server_", @"Error", nil);
Expand Down

9 comments on commit c2f77c6

@rakekniven
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marinofaggiana Looks like you finalized v2.19.2, or?
Could you please check status for milestone? For items are open. See https://github.com/nextcloud/ios/milestones/V2.19.2

@marinofaggiana
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.19.2 Yes, soon 2.19.3 .. I have found a "hide" bug ...

@rakekniven
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So shoud we shift remaining open issues to next version?

@marinofaggiana
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the new 2.19.3 today on apple review it's only for a "bug" ... thanks @rakekniven

@rakekniven
Copy link
Member

@rakekniven rakekniven commented on c2f77c6 Feb 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marinofaggiana That did not answer my question :-)

We have three open issues for v2.19.2.
What to do with them?

Shifting open issues to v2.19.3? No, you said this release is already at Apple as well? Or?

So we shift issues to v2.19.4?
Or removing milestone tag of them?

Please help maintaining issues at GitHub. Cheers.

@marinofaggiana
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes yes technically the issue are close with 2.19.2, waiting the users ?

2.19.3 is available on appstore but this version has only a little bug on manage error

thanks a lot @rakekniven

@mdelriog
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @marinofaggiana

First of all, thank you for these contributions.

I wanted to ask you the following:

  • I have installed Nextcloud App on my Iphone 6S (ios 10.3.2) and upload the photos and videos on my nextcloud server. However, the .mov videos do not upload and it says "Upload file, internal server error". How can I solve that?

  • On the other hand, with the photos uploaded does not increase the space on my iphone and I have marked that "optimized photo resolution". Why does not my space increase on the Iphone while the photos are up?

  • What is the purpose of "clean cache" in Nextcloud app?

Thank you very much!!!

@rakekniven
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mdelriog The discussion here on a commit was related to release information.

If you encounter a problem with the app then check https://github.com/nextcloud/ios/issues for existing issues or file a new one.

For other discussions about the app please visit the user forum at https://help.nextcloud.com/ and other users will help you.

@mdelriog
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's! @rakekniven

Please sign in to comment.