Improve performance of the "fix permissions" step in ncp-update-nc #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "fix permissions" step is really slow when the nextcloud folder contains a lot of data. In a docker setup the data directory is in nextcloud/data so the folder can be really big. Even on my small test setup the "fix permissions" step took more than 20 minutes. Using "chmod -R ..." reduces the time to around 20 seconds. Signed-off-by: Florian Wallner <[email protected]>
theCalcaholic
force-pushed
the
devel
branch
2 times, most recently
from
8d181e6 to
d9cb654
Compare
theCalcaholic
force-pushed
the
devel
branch
5 times, most recently
from
dce6a9f to
cdf99f6
Compare
theCalcaholic
force-pushed
the
devel
branch
2 times, most recently
from
ec7a07e to
9ed15a5
Compare
theCalcaholic
force-pushed
the
devel
branch
16 times, most recently
from
1ea55df to
287fe06
Compare
|
This should really be merged, the fix permissions step took more than 30 minutes on my setup. |
theCalcaholic
force-pushed
the
devel
branch
3 times, most recently
from
e24d3a0 to
f032fd7
Compare
theCalcaholic
force-pushed
the
devel
branch
8 times, most recently
from
75bffeb to
31d5ed9
Compare
theCalcaholic
force-pushed
the
devel
branch
17 times, most recently
from
f14678a to
0e40867
Compare
|
I would like to join in saying that improving the performance of “fix permissions” would be really helpful. On my instance the step also takes about 15 minutes (and I get nervous when it doesn't seem to continue during the update). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "fix permissions" step is really slow when the nextcloud folder contains a lot of data. In a docker setup the data directory is in nextcloud/data so the folder can be really big. Even on my small test setup the "fix permissions" step took more than 20 minutes. Using "chmod -R ..." reduces the time to around 20 seconds.
Signed-off-by: Florian Wallner [email protected]