Add rector config #48223
Merged
Add rector config #48223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
ChristophWurst,
miaulalala,
nickvergessen,
st3iny and
tcitworld
as code owners
provokateurin
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Can you add a script like https://github.com/nextcloud/groupfolders/blob/532f734b9d729a3c29a7371faf0bb85a24e0b311/composer.json#L26? This makes it a lot easier to use rector.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
provokateurin
requested changes
Sep 19, 2024
|
Uhm is it really supposed to run on 50323 files? To me it looks like it includes way too much. |
Only applying on apps for now, and only minimal type coverage level. Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
feat/add-rector-config
branch
from
ca417b5 to
f9f95cf
Compare
1877 for me |
|
Maybe because I have my cloned apps in apps/ as well, and then it also scans all the vendors of those and so on. |
provokateurin
approved these changes
Sep 20, 2024
Signed-off-by: Côme Chilliet <[email protected]>
nickvergessen
approved these changes
Sep 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
And so it begins…
Long term goal is to apply rectors from https://github.com/nextcloud-libraries/rector to core code. We’ll need to be extra careful with folders like lib/public because they use some deprecated stuff on purpose I think.
So not sure if the best way forward is to add more rules or more folders.
Checklist