-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Only keep allowed characters in appid, and flag the method as escaping #50794
Conversation
…caping Signed-off-by: Côme Chilliet <[email protected]>
/backport to stable31 |
/backport to stable30 |
/backport to stable29 |
…ppid Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/50794/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8f57a507 6e7c97ea
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50794/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/50794/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8f57a507 6e7c97ea
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50794/stable30 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
There are a few more psalm-taint types than what was listed, and I had to add the phpdoc on the implementation as well to get psalm to take it into account.
I also fixed the FIXME in there by only keeping explicitely allowed characters in appid.
Should be fine as the xsd schema is already enforcing this.
Checklist