Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only keep allowed characters in appid, and flag the method as escaping #50794

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Feb 13, 2025

  • Resolves: #

Summary

There are a few more psalm-taint types than what was listed, and I had to add the phpdoc on the implementation as well to get psalm to take it into account.

I also fixed the FIXME in there by only keeping explicitely allowed characters in appid.
Should be fine as the xsd schema is already enforcing this.

Checklist

@come-nc come-nc added the 3. to review Waiting for reviews label Feb 13, 2025
@come-nc come-nc requested review from nickvergessen and a team February 13, 2025 13:29
@come-nc come-nc self-assigned this Feb 13, 2025
@come-nc come-nc requested review from Altahrim, skjnldsv and yemkareems and removed request for a team February 13, 2025 13:29
@come-nc come-nc added this to the Nextcloud 32 milestone Feb 13, 2025
@come-nc
Copy link
Contributor Author

come-nc commented Feb 13, 2025

/backport to stable31

@come-nc
Copy link
Contributor Author

come-nc commented Feb 13, 2025

/backport to stable30

@come-nc
Copy link
Contributor Author

come-nc commented Feb 13, 2025

/backport to stable29

…ppid

Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc requested a review from susnux February 13, 2025 16:00
@come-nc come-nc enabled auto-merge February 13, 2025 16:22
@come-nc come-nc merged commit b003af2 into master Feb 13, 2025
189 checks passed
@come-nc come-nc deleted the fix/fix-appmanager-cleanappid branch February 13, 2025 16:23
Copy link

backportbot bot commented Feb 13, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/50794/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8f57a507 6e7c97ea

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50794/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Feb 13, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/50794/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8f57a507 6e7c97ea

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50794/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants