Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix all linter warnings #2762

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

jaylinski
Copy link
Member

Fixes all linter warnings:

> [email protected] lint
> eslint --ext .js,.vue src tests

/nextcloud-app-tasks/src/components/AppNavigation/Colorpicker.vue
  95:15  warning  Custom event name 'color-selected' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/AppSidebar/Alarm/AlarmDateTimePickerModal.vue
  75:15  warning  Custom event name 'select-date-time' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/AppSidebar/Alarm/AlarmList.vue
  128:15  warning  Custom event name 'add-alarm' must be camelCase     vue/custom-event-name-casing
  138:15  warning  Custom event name 'update-alarm' must be camelCase  vue/custom-event-name-casing
  147:15  warning  Custom event name 'remove-alarm' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/AppSidebar/Alarm/AlarmListItem.vue
  213:15  warning  Custom event name 'update-alarm' must be camelCase  vue/custom-event-name-casing
  223:15  warning  Custom event name 'update-alarm' must be camelCase  vue/custom-event-name-casing
  235:15  warning  Custom event name 'remove-alarm' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/AppSidebar/Alarm/AlarmListNew.vue
  217:15  warning  Custom event name 'add-alarm' must be camelCase  vue/custom-event-name-casing
  226:15  warning  Custom event name 'add-alarm' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/AppSidebar/Alarm/AlarmRelativeTimePickerModal.vue
  152:15  warning  Custom event name 'select-date-time' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/AppSidebar/CalendarPickerItem.vue
  111:15  warning  Custom event name 'change-calendar' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/AppSidebar/CheckboxItem.vue
  31:18  warning  Custom event name 'set-checked' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/AppSidebar/DateTimePickerItem.vue
  124:4  warning  Missing trailing comma  comma-dangle

/nextcloud-app-tasks/src/components/AppSidebar/MultiselectItem.vue
  103:15  warning  Custom event name 'change-value' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/AppSidebar/TagsItem.vue
  92:15  warning  Custom event name 'add-tag' must be camelCase   vue/custom-event-name-casing
  95:15  warning  Custom event name 'set-tags' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/TaskCheckbox.vue
  100:15  warning  Custom event name 'toggle-completed' must be camelCase  vue/custom-event-name-casing

/nextcloud-app-tasks/src/components/TaskStatusDisplay.vue
  89:15  warning  Custom event name 'status-clicked' must be camelCase  vue/custom-event-name-casing
  99:19  warning  Custom event name 'reset-status' must be camelCase    vue/custom-event-name-casing

/nextcloud-app-tasks/src/utils/dateStrings.js
  30:1  warning  The type 'Task' is undefined  jsdoc/no-undefined-types
  91:1  warning  The type 'Task' is undefined  jsdoc/no-undefined-types

/nextcloud-app-tasks/src/views/AppSidebar.vue
  175:21  warning  Expected to be enclosed by double quotes  vue/html-quotes

✖ 23 problems (0 errors, 23 warnings)
  0 errors and 2 warnings potentially fixable with the `--fix` option.

Signed-off-by: Jakob Linskeseder <[email protected]>
@jaylinski jaylinski force-pushed the chore/fix-linter-warnings branch from da8261c to 980e29d Compare January 18, 2025 19:42
@raimund-schluessler raimund-schluessler merged commit 746e0fb into master Jan 19, 2025
25 checks passed
@raimund-schluessler raimund-schluessler deleted the chore/fix-linter-warnings branch January 19, 2025 20:55
Copy link

github-actions bot commented Feb 1, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants