Upgrade shadow, squint and clerk #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please wait with merge, since I'm getting an issue locally: CodeMirror plugin crashed: TypeError: tag.set is not iterable |
|
Should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the newest squint, clj->js became a function instead of a no-op in the compiler.
While upgrading squint here in clojure-mode, I checked the performance implications of running
clj->jsover data structures but it seems to be very very minimal, so I'll leave those calls in for squint as well.I ran into an issue with shadow which didn't run anymore on my machine with JDK21+, so I upgraded that as well.
Furthermore I exported one more file which I needed for some experiment (replacing standard clojure style with the formatting provided by this library).