Namecoin Core flake #1

jurraca · 2021-08-27T22:49:04Z

Adds a Nix flake for Namecoin-Core.

TODO:

Notes:

~~I used the bitcoin nix expression to figure out the qt stuff but haven't managed to build it.~~
the versioning more or less matches bitcoin, might have to just hardcode it.
~~the core packages built fine until I added some of this qt stuff, but the error is that it can't find core cpp libraries. Stuck on this.~~

jurraca · 2021-09-06T21:01:56Z

so I'm kinda dead in the water with the Qt part of this @jonringer . Could we pair at some point?

jonringer · 2021-09-08T21:51:01Z

Yea, we can. Unfortunately I'm visiting family until the weekend. Sunday or monday?

the env vars should be conditional on the withGui value, but I couldn't figure it out so they are loaded globally.

jurraca · 2021-09-09T20:04:37Z

Yea, we can. Unfortunately I'm visiting family until the weekend. Sunday or monday?

I think I'm good actually! This last commit builds Qt successfully. Moving on to cleanup / container / module stuff.

flake.nix

jurraca · 2021-09-13T20:30:59Z

nix/namecoin-core.nix

+        ./configure --enable-cxx --without-bdb --disable-shared --prefix=${db48}/bin --with-boost=${boost} --with-boost-libdir=${boost}/lib --prefix=$out
+    '';
+
+    QT_PLUGIN_PATH = "${qtbase}/${qtbase.qtPluginPrefix}";


Couldn't figure out a way to get these evaluated correctly as optionals with withGui

null values get filtered out

Suggested change

QT_PLUGIN_PATH = "${qtbase}/${qtbase.qtPluginPrefix}";

QT_PLUGIN_PATH = if withGui then "${qtbase}/${qtbase.qtPluginPrefix}" else null;

nice. I was trying to get those four env vars declared as part of a phase where i could do
optionals withGui [ '' QT_PLUGIN_PATH = ... ;'', '' LRELEASE = ... '' ]
Is that an anti pattern or ?

I would probably do something like

} // lib.optionalAttrs withGui { QT_PLUGIN_PATH = "${qtbase}/${qtbase.qtPluginPrefix}"; .... }

nix/namecoin-core.nix

jonringer

I would also probably factor out the nixos module to a separate file

flake.nix

jonringer · 2021-09-14T20:06:08Z

flake.nix

@@ -25,6 +29,24 @@
      apps.namecoin-core = utils.lib.mkApp { drv = packages.namecoin-core; };
      hydraJobs = { inherit (legacyPackages) namecoin-core; };
      checks = { inherit (legacyPackages) namecoin-core; };
+      nixosModules.namecoin-core =
+        { ... }:


Suggested change

{ ... }:

{ lib, config, ... }:

jonringer · 2021-09-14T20:09:36Z

flake.nix

@@ -25,6 +29,24 @@
      apps.namecoin-core = utils.lib.mkApp { drv = packages.namecoin-core; };
      hydraJobs = { inherit (legacyPackages) namecoin-core; };
      checks = { inherit (legacyPackages) namecoin-core; };
+      nixosModules.namecoin-core =
+        { ... }:
+          {


Suggested change

{

with lib;

let

cfg = config.services.namecoin-core;

in {

options.services.namecoin-core = {

enable = lib.mkEnableOption "Namecoin-core";

withGui = lib.mkOption {

type = lib.types.bool;

default = false;

description = "Enable gui";

};

};

config = mkIf cfg.enable {

# what you had before

jurraca · 2021-09-15T21:05:18Z

Thanks 👍 . I'm trying to stay away from adding multiple files, just because I think it'll make it less likely for the upstream project to incorporate the flake. wdyt?

jonringer · 2022-07-28T17:33:19Z

@nrdsp and I had a really good chat. I think moving forward we should

Must:

Update the flake conventions
Update the upstream to a more recent checkout?
Check the packages still build

Optionally:

Somehow test the module (nixosTest?)

nrdsp · 2022-07-29T12:25:36Z

Following-up on @jonringer's comment above, I commited an update of flake conventions. More specifically, attributes defaultPackage and overlay were dropped in favour of packages.<system>.default and overlays.default. Nix flake check isn't throwing me any warning now.

nrdsp · 2022-07-29T15:54:25Z

@jonringer @jurraca ~~there are diverging changes with upstream. Should we attempt to force syncing and then try building?~~ synced my local copy of jurraca/namecoin-core with ngi-nix/namecoin-core and the updated flake seems to build without issues nor warnings. Maybe someone else could double check if the current flake builds against the upstream repository (ngi-nix/namecoin-core)?

nrdsp · 2022-08-01T22:49:16Z

@jonringer as to testing, should we implement any of the built-in integration tests?

nix/namecoin-core.nix

jonringer · 2022-09-11T18:58:26Z

nix/namecoin-core.nix

+    configureFlags = [ ]
+      ++ optionals (!withGui) [ " --without-gui " ]
+      ++ optionals (!withWallet) [ "--disable-wallet" "--without-bdb" ]
+      ++ optionals (withUpnp) [ "--with-miniupnpc" "--enable-upnp-default" ]
+      ++ optionals (withNatpmp) [ "--with-natpmp" "--enable-natpmp-default" ]
+      ++ optionals (!withHardening) [ "--disable-hardening" ] 
+      ++ optionals withGui [
+        "--with-gui=qt5"
+        "--with-qt-bindir=${qtbase.dev}/bin:${qttools.dev}/bin"
+      ];
+
+    configurePhase = ''
+        ./autogen.sh
+        ./configure --enable-cxx --without-bdb --disable-shared --prefix=${db48}/bin --with-boost=${boost} --with-boost-libdir=${boost}/lib --prefix=$out
+    '';


odd that we use both configureFlags, and then overwrite the default configure phase and call ./configure with specific flags. We should probably unify the flags into configureFlags, and move ./autogen.sh into preConfigure

Moving these flags into configureFlags doesn't seem to have the desired effect. For instance:

configureFlags = [ "--enable-cxx" "--without-bdb" "--disable-shared" "--prefix=${db48}/bin" "--with-boost=${boost}" "--with-boost-libdir=${boost}/lib" "--prefix=$out" ] ++ optionals (!withGui) [ " --without-gui " ] ++ optionals (!withWallet) [ "--disable-wallet" "--without-bdb" ] ++ optionals (withUpnp) [ "--with-miniupnpc" "--enable-upnp-default" ] ++ optionals (withNatpmp) [ "--with-natpmp" "--enable-natpmp-default" ] ++ optionals (!withHardening) [ "--disable-hardening" ] ++ optionals withGui [ "--with-gui=qt5" "--with-qt-bindir=${qtbase.dev}/bin:${qttools.dev}/bin" ]; configurePhase = '' ./configure '';

The above gives us:

> checking whether to build Namecoin Core GUI... yes (Qt5) > checking for Berkeley DB C++ headers... no > configure: error: libdb_cxx headers missing, Namecoin Core requires this library for BDB wallet support (--without-bdb to disable BDB wallet support)

Adding the flag "--without-bdb" to ++ optionals withGui doesn't do much either.

Co-authored-by: Jonathan Ringer <[email protected]>

portothree · 2022-09-19T11:54:08Z

Hey, I tried consuming this flake nixos module and encountered the following error:

error: attribute 'namecoin-core' missing

       at /nix/store/p0ivsgkf349snq28mba2viva6h3sny3v-source/flake.nix:100:13:

           99|             microvm.nixosModules.host
          100|             namecoin-core.nixosModules.namecoin-core
             |             ^
          101|           ];

After inspecting the flake with nix flake show, I can see that the output of namecoin-core.nixosModules does not have a namecoin-core value, it has a list of systems instead. My guess was that this was being caused because the nixosModules is being defined inside the flake-utils eachSystem function, causing each ouput value to have a list of system before the actual closure value.

➜  nix flake show github:jurraca/namecoin-core/flake
github:jurraca/namecoin-core/dfa1676ab3531b34667fc51540338cf538be0ea5
[...]
├───nixosModules
│   ├───aarch64-linux: NixOS module
│   ├───x86_64-darwin: NixOS module
│   └───x86_64-linux: NixOS module
[...]

I have paired with @nrdsp to explore this and we end up finding a solution.
We moved the nixosModules definition to outside of the eachSystem call and replace defaultPackage reference inside the module definition with pkgs.namecoin-core given that we are using a overlay for the nixpkgs to include namecoin-core in the store.

This worked fine and now I can do the following:

pkgs.lib.nixosSystem {
    modules = [ namecoin-core.nixosModules.namecoin-core ];

in my flake.nix.

@jonringer Could you have a look at this change and let me know if this is the best option to solve this, please? 🙏

jurraca added 2 commits August 11, 2021 18:22

move flake to template

681ed46

add qt things, break compile again

ecf640a

jurraca marked this pull request as draft August 27, 2021 22:50

setup Qt; works, except for a missing plugin

3b6cf4b

build Qt correctly with qmake;

472d7a9

the env vars should be conditional on the withGui value, but I couldn't figure it out so they are loaded globally.

jurraca added 2 commits September 10, 2021 12:10

add systemd module

a23da80

remove separate overlay file and merge into flake.nix

196ad31

jurraca marked this pull request as ready for review September 10, 2021 17:15

move build options to inputs, move wrapQtAppsHook to optionals

42bf829

jurraca commented Sep 13, 2021

View reviewed changes

flake.nix Outdated Show resolved Hide resolved

jurraca commented Sep 13, 2021

View reviewed changes

jonringer reviewed Sep 14, 2021

View reviewed changes

nix/namecoin-core.nix Outdated Show resolved Hide resolved

fix optional env var and qt out dir

1071d23

jonringer reviewed Sep 14, 2021

View reviewed changes

fix module expression

e2aaa98

jurraca requested a review from jonringer September 20, 2021 17:51

nrdsp self-assigned this Jul 28, 2022

updated flake conventions

dfa1676

jonringer reviewed Sep 11, 2022

View reviewed changes

nrdsp and others added 2 commits September 18, 2022 19:03

already default

a271e05

Co-authored-by: Jonathan Ringer <[email protected]>

Use NIX_BUILD_CORES environment variable.

5212055

Co-authored-by: Jonathan Ringer <[email protected]>

nrdsp assigned portothree Sep 19, 2022

portothree added 2 commits September 19, 2022 12:31

fix: define nixosModules outside eachSystem

2f46847

refactor: use pkgs.namecoin-core directly

6e849ac

portothree requested a review from jonringer September 19, 2022 11:54

nrdsp added 5 commits September 30, 2022 16:14

Update versioning.

15a5bda

Update version.

469419a

update flake

e9910e9

Updated version, dynamically changing it seems undesirable.

8a1ec66

Moved autogen.sh to preConfigure phase.

9cb115d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Namecoin Core flake #1

Namecoin Core flake #1

jurraca commented Aug 27, 2021 •

edited by nrdsp

Loading

jurraca commented Sep 6, 2021

jonringer commented Sep 8, 2021

jurraca commented Sep 9, 2021

jurraca Sep 13, 2021

jonringer Sep 14, 2021

jurraca Sep 14, 2021

jonringer Sep 14, 2021

jonringer left a comment

jonringer Sep 14, 2021

jonringer Sep 14, 2021

jurraca commented Sep 15, 2021

jonringer commented Jul 28, 2022 •

edited by nrdsp

Loading

nrdsp commented Jul 29, 2022 •

edited

Loading

nrdsp commented Jul 29, 2022 •

edited

Loading

nrdsp commented Aug 1, 2022 •

edited

Loading

jonringer Sep 11, 2022

nrdsp Sep 20, 2022 •

edited

Loading

portothree commented Sep 19, 2022

	QT_PLUGIN_PATH = "${qtbase}/${qtbase.qtPluginPrefix}";
	QT_PLUGIN_PATH = if withGui then "${qtbase}/${qtbase.qtPluginPrefix}" else null;

-          {
+    with lib;
+    let
+      cfg = config.services.namecoin-core;
+    in {
+      options.services.namecoin-core = {
+        enable = lib.mkEnableOption "Namecoin-core";
+        withGui = lib.mkOption {
+          type = lib.types.bool;
+          default = false;
+          description = "Enable gui";
+        };
+      };
+      config = mkIf cfg.enable {
+        # what you had before

Namecoin Core flake #1

Are you sure you want to change the base?

Namecoin Core flake #1

Conversation

jurraca commented Aug 27, 2021 • edited by nrdsp Loading

jurraca commented Sep 6, 2021

jonringer commented Sep 8, 2021

jurraca commented Sep 9, 2021

jurraca Sep 13, 2021

Choose a reason for hiding this comment

jonringer Sep 14, 2021

Choose a reason for hiding this comment

jurraca Sep 14, 2021

Choose a reason for hiding this comment

jonringer Sep 14, 2021

Choose a reason for hiding this comment

jonringer left a comment

Choose a reason for hiding this comment

jonringer Sep 14, 2021

Choose a reason for hiding this comment

jonringer Sep 14, 2021

Choose a reason for hiding this comment

jurraca commented Sep 15, 2021

jonringer commented Jul 28, 2022 • edited by nrdsp Loading

nrdsp commented Jul 29, 2022 • edited Loading

nrdsp commented Jul 29, 2022 • edited Loading

nrdsp commented Aug 1, 2022 • edited Loading

jonringer Sep 11, 2022

Choose a reason for hiding this comment

nrdsp Sep 20, 2022 • edited Loading

Choose a reason for hiding this comment

portothree commented Sep 19, 2022

jurraca commented Aug 27, 2021 •

edited by nrdsp

Loading

jonringer commented Jul 28, 2022 •

edited by nrdsp

Loading

nrdsp commented Jul 29, 2022 •

edited

Loading

nrdsp commented Jul 29, 2022 •

edited

Loading

nrdsp commented Aug 1, 2022 •

edited

Loading

nrdsp Sep 20, 2022 •

edited

Loading