Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endpoints bind to a single binding #198

Merged
merged 5 commits into from
Jan 22, 2025
Merged

endpoints bind to a single binding #198

merged 5 commits into from
Jan 22, 2025

Conversation

Megalonia
Copy link
Contributor

moving towards 1 binding per endpoint

Megalonia
Megalonia commented Jan 22, 2025
View reviewed changes
config/bindings.go Outdated Show resolved Hide resolved
@Megalonia Megalonia changed the title update ingress to only have a singular binding only bind endpoints to a single ingress binding Jan 22, 2025
@Megalonia Megalonia changed the title only bind endpoints to a single ingress binding endpoint only bind to a single binding Jan 22, 2025
@Megalonia Megalonia changed the title endpoint only bind to a single binding endpoints only bind to a single binding Jan 22, 2025
@rkolavo
Copy link
Contributor

rkolavo commented Jan 22, 2025

believe you'd want a changelog

@Megalonia Megalonia changed the title endpoints only bind to a single binding endpoints bind to a single binding Jan 22, 2025
@Megalonia Megalonia merged commit 2d002d1 into main Jan 22, 2025
2 checks passed
@Megalonia Megalonia deleted the mo/bindings-to-binding branch January 22, 2025 17:56
@Megalonia Megalonia mentioned this pull request Jan 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abdiramen Abdiramen Abdiramen approved these changes

@tammybailey tammybailey tammybailey approved these changes

@rkolavo rkolavo Awaiting requested review from rkolavo

@masonj5n masonj5n Awaiting requested review from masonj5n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Megalonia @rkolavo @Abdiramen @tammybailey