Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keyboard-key.component.ts #51

Closed
wants to merge 1 commit into from
Closed

Update keyboard-key.component.ts #51

wants to merge 1 commit into from

Conversation

ydock1
Copy link

@ydock1 ydock1 commented Mar 8, 2018

solved:
"value.slice is not a function" <- (when the textbox is empty)
Backspace not working

@ydock1
Update keyboard-key.component.ts
bf7f1c0 
solved:
 "value.slice is not a function" <- (when the textbox is empty)
 Backspace not working
@ydock1 ydock1 mentioned this pull request Mar 8, 2018
Open
@RANSoftRA
Copy link

tried that fix - works for me.

@RANSoftRA
Copy link

sry - just figured out that this change only fixes the problem described in #49 - not when the input is prefilled with a number #50

@RANSoftRA RANSoftRA mentioned this pull request Mar 10, 2018
Open
@RANSoftRA
Copy link

RANSoftRA commented Mar 10, 2018 •
edited
Loading

just created a new PR #55 that includes your @ydock1 fixes and also casts the input value to string, so that #50 does not happen.

@davidenke
Copy link
Collaborator

Closing, since this seams to be part of #55.

@davidenke davidenke closed this Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydock1 @RANSoftRA @davidenke