Terraform backup module #3131
Draft
Terraform backup module #3131
+1,186
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add both in same account for testing * Remove duplicate locale definition * Comment out testing config as it requires another provider
* This broke the terraform apply
* The automated backup job picks up all resources with this tag and includes it in the backup
* For both source and destination account, the S3 bucket and the dynamodb table has to exist prior to running the first terraform apply
* Only this role will be able to delete recovery points etc
* Only this role will be able to delete recovery points etc. * For the moment, use Admin role
* Now that the terraform_role_arn is a valid Principal ARN, this check can be included again
* We are not backing up S3 at this stage so lets just do RDS * Also applied formatter to README.md files
* Aurora is the correct type of the DB cluster that is backed up. RDS is the type of the DB instance
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.