Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a SchoolMove is always applied to new patients #3145

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Mar 5, 2025

When creating a patient for the first time during importing, we need to make sure the SchoolMove is created so that the patient is attached to the organisation, even if the school move is to "unknown school" (which the patient would already be classed as).

This is because the school move is what adds the patient in to the cohort, and without it, the patients will be imported but not added to the cohort (or any sessions in the clinic).

@thomasleese thomasleese added the 🐞 bug Something isn't working label Mar 5, 2025
@thomasleese thomasleese force-pushed the ensure-patient-organisation-is-set branch from 5f28b43 to b73ffb7 Compare March 5, 2025 16:33
@thomasleese thomasleese changed the title Ensure a SchoolMove is applied to new patients Ensure a SchoolMove is always applied to new patients Mar 5, 2025
@thomasleese thomasleese marked this pull request as ready for review March 5, 2025 16:33
@thomasleese thomasleese force-pushed the ensure-patient-organisation-is-set branch from b73ffb7 to 8ee530d Compare March 5, 2025 16:34
@thomasleese thomasleese added this to the v2.1.0 milestone Mar 5, 2025
@thomasleese thomasleese changed the base branch from main to v2.1.0-wip March 5, 2025 16:37
When creating a patient for the first time during importing, we need to
make sure the `SchoolMove` is created so that the patient is attached to
the organisation, even if the school move is to "unknown school" (which
the patient would already be classed as).

This is because the school move is what adds the patient in to the
cohort, and without it, the patients will be imported but not added to
the cohort (or any sessions in the clinic).
@thomasleese thomasleese force-pushed the ensure-patient-organisation-is-set branch from 8ee530d to 7e3e5bf Compare March 5, 2025 16:38
@tvararu tvararu temporarily deployed to mavis-pr-3145 March 5, 2025 16:38 Inactive
Copy link

sonarqubecloud bot commented Mar 5, 2025

@thomasleese thomasleese merged commit 7c22d02 into v2.1.0-wip Mar 6, 2025
11 checks passed
@thomasleese thomasleese deleted the ensure-patient-organisation-is-set branch March 6, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants