Update dependencies for Angular, RxJS, karma, jasmine, and @ni/eslint-config #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
approved these changes
Sep 7, 2021
fredvisser
approved these changes
Sep 8, 2021
rajsite
reviewed
Sep 8, 2021
1 task
rajsite
added a commit
that referenced
this pull request
Oct 5, 2021
# Pull Request ## π€¨ Rationale After vendoring [storybook-addon-xd-designs](#104) local npm installs of nimble result in dirty lock file changes as the paths used in the lock file switch from linux paths to windows paths. This change makes it so that a local `npm install` on windows does not result in a dirty lockfile. ## π©βπ» Implementation Moved the tgz for the addon to be next to the package.json so the relative paths in the lockfile do not include platform-specific delimeters. ## π§ͺ Testing A full verification will be after merging and testing npm install on Windows. ## β Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
rajsite
pushed a commit
that referenced
this pull request
Mar 15, 2022
β¦ may require windows after all (#104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Good to keep our dependencies up to date.
π©βπ» Implementation
π§ͺ Testing
Relying on automated testing.
β Checklist