Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Loop When TypeRef References Parent TypeRef #49

Closed
seanmarpo opened this issue Aug 18, 2022 · 1 comment · Fixed by #66
Closed

Infinite Loop When TypeRef References Parent TypeRef #49

seanmarpo opened this issue Aug 18, 2022 · 1 comment · Fixed by #66
Labels
bug Something isn't working

Comments

@seanmarpo
Copy link

Clairvoyance cannot handle when a schema typeref back-references a typeref. The tool ends up stuck in an infinite loop and never progresses.

The tool gets caught in get_path_from_root() in graphql.py where there is a while loop that never completes. I ended up monkey-patching the oracle.py to avoid specific TypeName's that have this back reference.

Attached is a screenshot of a schema which does this. I had to kill the tool and the resulting schema showed the issue when thrown into a visualizer.
Screen Shot 2022-08-17 at 11 24 53 PM

@nikitastupin
Copy link
Owner

Hey @seanmarpo,

Thank you for reporting the issue and the detailed report! We'll try to solve this systematically once we have time.

Also, feel free to submit a pull request if you have the solution in mind 😃

@nikitastupin nikitastupin added the bug Something isn't working label Aug 18, 2022
@nikitastupin nikitastupin linked a pull request Mar 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants