-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lot of fixes, improvements etc... #66
Conversation
Signed-off-by: QuentinN42 <[email protected]>
…-query-regex Duplicate query regex
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
fix: double regex
…to fix/double_regexes
Signed-off-by: QuentinN42 <[email protected]>
feat: add backoff
Signed-off-by: QuentinN42 <[email protected]>
This reverts commit 200f43b.
Signed-off-by: QuentinN42 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start of the review
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review done, need to test it on any python versions.
Working from python 3.8 to python 3.11 |
Thanks @QuentinN42! I'm going to review as soon as possible. |
Signed-off-by: QuentinN42 <[email protected]>
### From BlackArch Linux | ||
|
||
> NOTE: this distribution is supported by a third-party (i.e. not by the mainainters of clairvoyance) | ||
|
||
```bash | ||
pacman -S clairvoyance | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind bringing this back? Any arguments against this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to introduce small edits but they're not related to code. So I'm going to merge this and edit in the main branch. Thank you very much for the contributions 💪 Looks amazing 👏
Here is a list of some improvements made to clairvoyance:
0c4902e
: feat: progress bar as an optional parameter099fba1
: feat: use pathlib to work with any OScdf0076
: docs: update readmedf6b6d2
: fix: don't crash when no field suggestionb5e8c71
: feat: disable ssl verification as an optional parameterd7e7e63
: fix: reccursive schemas loopsf842156
: ignore aiohttp warnsac00768
: @jamboro fixes issue 1136a0217
: replace prints by loggerf5fa684
: feat: add backoff as an optional parameter038c0f4
: feat: add max retry param2e97088
: feat: proxy as an optional parameter