Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lot of fixes, improvements etc... #66

Merged
merged 98 commits into from
Mar 18, 2023

Conversation

QuentinN42
Copy link
Collaborator

Here is a list of some improvements made to clairvoyance:

  • fixed a lot of regexes
  • 0c4902e : feat: progress bar as an optional parameter
  • 099fba1 : feat: use pathlib to work with any OS
  • cdf0076 : docs: update readme
  • df6b6d2 : fix: don't crash when no field suggestion
  • b5e8c71 : feat: disable ssl verification as an optional parameter
  • d7e7e63 : fix: reccursive schemas loops
  • f842156 : ignore aiohttp warns
  • ac00768 : @jamboro fixes issue 11
  • 36a0217 : replace prints by logger
  • f5fa684 : feat: add backoff as an optional parameter
  • 038c0f4 : feat: add max retry param
  • 2e97088 : feat: proxy as an optional parameter

iCarossio and others added 30 commits February 9, 2023 12:07
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
@QuentinN42 QuentinN42 self-assigned this Mar 15, 2023
@QuentinN42 QuentinN42 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Mar 15, 2023
Signed-off-by: QuentinN42 <[email protected]>
Copy link
Collaborator Author

@QuentinN42 QuentinN42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start of the review

Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Signed-off-by: QuentinN42 <[email protected]>
Copy link
Collaborator Author

@QuentinN42 QuentinN42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review done, need to test it on any python versions.

@QuentinN42
Copy link
Collaborator Author

Working from python 3.8 to python 3.11

@nikitastupin
Copy link
Owner

Thanks @QuentinN42! I'm going to review as soon as possible.

Signed-off-by: QuentinN42 <[email protected]>
Comment on lines -51 to -57
### From BlackArch Linux

> NOTE: this distribution is supported by a third-party (i.e. not by the mainainters of clairvoyance)

```bash
pacman -S clairvoyance
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind bringing this back? Any arguments against this?

Copy link
Owner

@nikitastupin nikitastupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to introduce small edits but they're not related to code. So I'm going to merge this and edit in the main branch. Thank you very much for the contributions 💪 Looks amazing 👏

@nikitastupin nikitastupin merged commit de71a0f into nikitastupin:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
4 participants